N21 2089 placeholder element media shelf #3401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…ia-shelf' into N21-2089-placeholder-element-media-shelf
MarvinOehlerkingCap
requested changes
Sep 16, 2024
| :data-element-id="element.id" | ||
| :key="element.id" |
There was a problem hiding this comment.
Are you sure that "key" is not needed anymore. There was a bug where the DOM was desynchronized with the data structure of the list that the Sortable component uses. The key attribute prevented that elements would duplicate in the DOM.
There was a problem hiding this comment.
From Vue 3 onwards, the key attributes in on "v-if/else" branches are generated automatically: https://v3-migration.vuejs.org/breaking-changes/key-attribute#on-conditional-branches. So, the keys are actually still there.
MarvinOehlerkingCap
previously approved these changes
Sep 16, 2024
…ia-shelf' into N21-2089-placeholder-element-media-shelf
|
MarvinOehlerkingCap
approved these changes
Sep 17, 2024
GordonNicholasCap
deleted the
N21-2089-placeholder-element-media-shelf
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Links to Ticket and related Pull-Requests
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging