Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-6965 - Fix videoconference guest label bug #4943

Merged
merged 21 commits into from
Apr 30, 2024

Conversation

davwas
Copy link
Contributor

@davwas davwas commented Apr 18, 2024

Description

QA note:change tested on env:
https://bc-6965-fix-videoconference-guest.dbc.dbildungscloud.dev/
https://bc-6965-fix-videoconference-guest.nbc.dbildungscloud.dev/
https://bc-6965-fix-videoconference-guest.brb.dbildungscloud.dev/
No issues found. Tested videoconf on course and team. see ticket:
https://ticketsystem.dbildungscloud.de/browse/BC-6965

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-6965

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@davwas davwas self-assigned this Apr 18, 2024
Copy link

sonarcloud bot commented Apr 29, 2024

@CeEv CeEv self-requested a review April 30, 2024 06:32
Copy link
Contributor

@CeEv CeEv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on approval of @alweber-cap you can merge.

@wiaderwek wiaderwek merged commit ecac83a into main Apr 30, 2024
55 of 56 checks passed
@wiaderwek wiaderwek deleted the BC-6965-fix-videoconference-guest branch April 30, 2024 07:20
bergatco pushed a commit that referenced this pull request May 6, 2024
* fix videoconference guest label

---------

Co-authored-by: wiaderwek <t.wiaderwek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants