-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-6965 - Fix videoconference guest label bug #4943
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiaderwek
approved these changes
Apr 19, 2024
Quality Gate passedIssues Measures |
alweber-cap
approved these changes
Apr 30, 2024
CeEv
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on approval of @alweber-cap you can merge.
bergatco
pushed a commit
that referenced
this pull request
May 6, 2024
* fix videoconference guest label --------- Co-authored-by: wiaderwek <t.wiaderwek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QA note:change tested on env:
https://bc-6965-fix-videoconference-guest.dbc.dbildungscloud.dev/
https://bc-6965-fix-videoconference-guest.nbc.dbildungscloud.dev/
https://bc-6965-fix-videoconference-guest.brb.dbildungscloud.dev/
No issues found. Tested videoconf on course and team. see ticket:
https://ticketsystem.dbildungscloud.de/browse/BC-6965
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/BC-6965
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:server
was executed in vue frontend and changes were tested and put in a PR with the same branch name.