Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-7185 - fix unexpected EXIT_ON_ERROR values #4949

Merged
merged 6 commits into from
Apr 22, 2024

Conversation

bn-pass
Copy link
Contributor

@bn-pass bn-pass commented Apr 21, 2024

Description

Links to Tickets or other pull requests

ticket: https://ticketsystem.dbildungscloud.de/browse/BC-7185
other PR: hpi-schul-cloud/dof_app_deploy#851

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link
Member

@Loki-Afro Loki-Afro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change it to EXIT_ON_ERROR: "true" on all 3 cases

you are only using new code here, e.g. non-feathers code, code that has to be run fine. if it doesn't fix the underlying issue

@bn-pass bn-pass requested a review from Loki-Afro April 22, 2024 10:27
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@bn-pass bn-pass merged commit f58e0f2 into main Apr 22, 2024
56 of 57 checks passed
@bn-pass bn-pass deleted the BC-7185-change-def-exit-on-error branch April 22, 2024 12:50
virgilchiriac pushed a commit that referenced this pull request Apr 22, 2024
* set EXIT_ON_ERROR to false for main API ConfigMap

* revert EXIT_ON_ERROR in api's ConfigMap as it doesn't work

* change the EXIT_ON_ERROR env var value back to true (as false is default back again)

* explicitly set EXIT_ON_ERROR to false for the Admin API deployment's ConfigMap

* change EXIT_ON_ERROR to true
bergatco pushed a commit that referenced this pull request May 6, 2024
* set EXIT_ON_ERROR to false for main API ConfigMap

* revert EXIT_ON_ERROR in api's ConfigMap as it doesn't work

* change the EXIT_ON_ERROR env var value back to true (as false is default back again)

* explicitly set EXIT_ON_ERROR to false for the Admin API deployment's ConfigMap

* change EXIT_ON_ERROR to true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants