Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-7655 cleanup shared #5107

Merged
merged 8 commits into from
Jul 17, 2024
Merged

BC-7655 cleanup shared #5107

merged 8 commits into from
Jul 17, 2024

Conversation

CeEv
Copy link
Contributor

@CeEv CeEv commented Jul 15, 2024 •
edited
Loading

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@CeEv CeEv added the WIP This feature branch is in progress, do not merge into master. label Jul 15, 2024
@CeEv CeEv removed the WIP This feature branch is in progress, do not merge into master. label Jul 15, 2024
@CeEv CeEv requested a review from Metauriel July 15, 2024 15:50
@CeEv CeEv enabled auto-merge (squash) July 17, 2024 08:18
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@CeEv CeEv merged commit 216adda into main Jul 17, 2024
54 of 55 checks passed
@CeEv CeEv deleted the BC-7655-cleanup-shared branch July 17, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Metauriel Metauriel Metauriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CeEv @Metauriel