Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1824 Course resync #5115

Merged
merged 34 commits into from
Jul 29, 2024
Merged

N21-1824 Course resync #5115

merged 34 commits into from
Jul 29, 2024

Conversation

IgorCapCoder
Copy link
Contributor

@IgorCapCoder IgorCapCoder commented Jul 17, 2024 •
edited by MarvinOehlerkingCap
Loading

Description

Synchronized courses that gets disonnected because of a lack of the connected group can be resynchronized again.

  • data model changes
  • empty groups, that have a connected course are not deleted
  • courses will not be synced anymore when the last teacher would have been removed. The teacher will stay in course.

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@IgorCapCoder
- data model changes
3e94225 
- TODO: add lastSyncAt in unit tests
@IgorCapCoder IgorCapCoder added the WIP This feature branch is in progress, do not merge into master. label Jul 17, 2024
IgorCapCoder and others added 26 commits July 17, 2024 16:51
@IgorCapCoder
- update lastSyncedAt when provisioning group
9e5eb96 
- fix tests
@IgorCapCoder
Merge branch 'main' into N21-1824-course-resync
e2ffd75
@sdinkov
update group deletion + sync course logic
be7e127
@sdinkov
Merge branch 'main' into N21-1824-course-resync
d3e819b
@sdinkov
Merge branch 'main' into N21-1824-course-resync
fadd208
@IgorCapCoder
Merge branch 'main' into N21-1824-course-resync
63e3c31
@sdinkov
update group provisioning + tests
f9f9c40
@sdinkov
update course/group-provisioning tests
a722a70
@sdinkov
Merge branch 'main' into N21-1824-course-resync
6553f42
@mrikallab
N21-1824 migration script
35ae019
@IgorCapCoder
Merge remote-tracking branch 'origin/N21-1824-course-resync' into N21…
1383883 
…-1824-course-resync
@IgorCapCoder
Merge branch 'main' into N21-1824-course-resync
b21874a
@IgorCapCoder
- group.repo.spec.ts still failing tests
9874734
@IgorCapCoder
Merge branch 'main' into N21-1824-course-resync
29f3782
@mrikallab
N21-2095 seed data
9e31385
@mrikallab
N21-2095 migr script fix
aaf8e95
@mrikallab
N21-2095 fix seed data
7cdc559
@mrikallab
migration: Migration20240719115036
1318bbe
@mrikallab
migration: Migration20240719115036
f1a3c04
@mrikallab
migration: Migration20240719115036
32832fe
@IgorCapCoder
Merge remote-tracking branch 'origin/N21-1824-course-resync' into N21…
a827406 
…-1824-course-resync
@IgorCapCoder
Merge branch 'main' into N21-1824-course-resync
54a706f
@IgorCapCoder
fix group search
1bb7ab9
@IgorCapCoder
fix empty group save
3d97634
@IgorCapCoder
Merge branch 'main' into N21-1824-course-resync
141272f 
# Conflicts:
#	backup/setup/migrations.json
@sdinkov
Merge branch 'main' into N21-1824-course-resync
c132a98
arnegns
arnegns previously requested changes Jul 26, 2024
View reviewed changes
apps/server/src/migrations/mikro-orm/Migration20240719115036.ts Show resolved Hide resolved
apps/server/src/migrations/mikro-orm/Migration20240719115036.ts Outdated Show resolved Hide resolved
...erver/src/modules/provisioning/strategy/oidc/service/schulconnex-course-sync.service.spec.ts Show resolved Hide resolved
...rc/modules/provisioning/strategy/oidc/service/schulconnex-group-provisioning.service.spec.ts Outdated Show resolved Hide resolved
...rc/modules/provisioning/strategy/oidc/service/schulconnex-group-provisioning.service.spec.ts Show resolved Hide resolved
...rc/modules/provisioning/strategy/oidc/service/schulconnex-group-provisioning.service.spec.ts Show resolved Hide resolved
...rc/modules/provisioning/strategy/oidc/service/schulconnex-group-provisioning.service.spec.ts Show resolved Hide resolved
apps/server/src/modules/group/repo/group.repo.spec.ts Outdated Show resolved Hide resolved
...ver/src/modules/provisioning/strategy/oidc/service/schulconnex-group-provisioning.service.ts Outdated Show resolved Hide resolved
@sdinkov sdinkov removed the WIP This feature branch is in progress, do not merge into master. label Jul 29, 2024
@IgorCapCoder IgorCapCoder dismissed arnegns’s stale review July 29, 2024 12:20

everything is fine now :)

@IgorCapCoder IgorCapCoder mentioned this pull request Jul 29, 2024
Closed
3 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sdinkov sdinkov merged commit 8dc5c63 into main Jul 29, 2024
54 of 55 checks passed
@sdinkov sdinkov deleted the N21-1824-course-resync branch July 29, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvinOehlerkingCap MarvinOehlerkingCap MarvinOehlerkingCap approved these changes

@arnegns arnegns arnegns left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IgorCapCoder @arnegns @MarvinOehlerkingCap @sdinkov @mrikallab