Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EW-995 Add new tsp service and tsp rest client #5236

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

SimoneRadtke-Cap
Copy link
Contributor

Description

To be able to implement TSPStrategy and later on to realize the TSP Sync first a TSPService and a TSPRestClient has to be created.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/EW-995

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@SimoneRadtke-Cap SimoneRadtke-Cap self-assigned this Sep 12, 2024
jti: uuidv4(),
};

const token: string = jwt.sign(payload, 'secret');

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical

The hard-coded value "secret" is used as
jwt key
.
Copy link

sonarcloud bot commented Sep 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)
3.5% Duplication on New Code (required ≤ 3%)
225 Uncovered Lines on New Code (required ≤ 0)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants