EW-999 adding school change and classes provisioning to tsp sync #5237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psachmann
changed the title
alweber-cap
requested changes
Sep 17, 2024
|
|
||
| private static getBaseProps(): ClassProps { | ||
| return { | ||
| id: '', |
There was a problem hiding this comment.
Empty IDs are dangerous. Create a new one already here
alweber-cap
approved these changes
Sep 19, 2024
| private readonly accountService: AccountService | ||
| ) {} | ||
|
|
||
| public async findSchoolOrFail(system: ProvisioningSystemDto, school: ExternalSchoolDto): Promise<School> { |
There was a problem hiding this comment.
This sounds like a function that should rather exists in the SchoolModule, but I won't insist on it now
WahlMartin
approved these changes
Sep 20, 2024
| if (existingUser && school.externalId === data.externalSchool?.externalId) { | ||
| // Case: User exists and school is the same -> update user | ||
| user = await this.updateUser(existingUser, data.externalUser, roleRefs, school.id); | ||
| } else if (existingUser && school.id !== data.externalSchool?.externalId) { |
There was a problem hiding this comment.
Shouldn't it be school.externalId?
Suggested change
| } else if (existingUser && school.id !== data.externalSchool?.externalId) { | |
| } else if (existingUser && school.externalId !== data.externalSchool?.externalId) { | |
| schoolId: string | ||
| ): Promise<UserDO> { | ||
| if (!externalUser.firstName || !externalUser.lastName || !externalUser.email) { | ||
| throw new BadDataLoggableException('User firstname, lastname and email is missing', { externalUser }); |
There was a problem hiding this comment.
Suggested change
| throw new BadDataLoggableException('User firstname, lastname and email is missing', { externalUser }); | |
| throw new BadDataLoggableException('User firstname, lastname or email is missing', { externalUser }); | |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding class provisioning and school change functionality during a tsp sync.
Links to Tickets or other pull requests
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.