Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create clean action.yml #12

Merged
merged 7 commits into from
Jul 13, 2023
Merged

Create clean action.yml #12

merged 7 commits into from
Jul 13, 2023

Conversation

VikDavydiuk
Copy link
Contributor

@VikDavydiuk VikDavydiuk commented Jul 12, 2023 •
edited
Loading

Description

Links to Tickets or other pull requests

- https://ticketsystem.dbildungscloud.de/browse/BC-4441

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Screenshots of UI changes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@VikDavydiuk VikDavydiuk requested a review from bn-pass July 12, 2023 14:59
@VikDavydiuk VikDavydiuk self-assigned this Jul 12, 2023
bn-pass
bn-pass suggested changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@bn-pass bn-pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this to give the clean job just the read permissions to the repo contents:

    permissions:
      contents: read

@VikDavydiuk VikDavydiuk requested a review from bn-pass July 12, 2023 18:14
@VikDavydiuk VikDavydiuk merged commit 84d5f35 into master Jul 13, 2023
21 checks passed
@VikDavydiuk VikDavydiuk deleted the Create-clean-action branch July 13, 2023 09:13
VikDavydiuk added a commit that referenced this pull request Jul 15, 2023
@VikDavydiuk
Changes from the master to the main (#16)
ef2e9e7 
* Create clean action.yml (#12)

* Create clean.yml

* Add contents:read

* Update modules

* fix issue

---------

Co-authored-by: Viktoriia <1>

* Create tag.yml (#14)

* Create tag.yml

* Change version

---------

Co-authored-by: Viktoriia <1>
VikDavydiuk added a commit that referenced this pull request Jul 17, 2023
@VikDavydiuk
Fix tests (#17)
b3e395c 
* Create clean action.yml (#12)

* Create clean.yml

* Add contents:read

* Update modules

* fix issue

---------

Co-authored-by: Viktoriia <1>

* Fix tests and refactor code

* Update README file

* Add eslint

* Fix comment

* fix comments

* Update README

* Fix

* Prettier config

* Prettier format

---------

Co-authored-by: Viktoriia <1>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bn-pass bn-pass bn-pass approved these changes

Assignees

@VikDavydiuk VikDavydiuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VikDavydiuk @bn-pass