Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-7894 Add file deletion and restore on file delete, undo and redo #82

Merged
merged 26 commits into from
Sep 3, 2024

Conversation

bischofmax
Copy link
Contributor

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Screenshots of UI changes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@bischofmax bischofmax self-assigned this Aug 20, 2024
@@ -407,7 +410,6 @@ export function useMultiplayerState({
) => {
if (!(yShapes && yBindings && yAssets)) return;

undoManager.stopCapturing();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hier kann ich nicht sagen welche Auswirkung es hat. Sollen wir Verhalten noch mal mit main vergleichen oder soll Christian das tun?

src/utils/handleAssets.ts Outdated Show resolved Hide resolved
src/utils/handleAssets.ts Outdated Show resolved Hide resolved
@bischofmax bischofmax merged commit ee1fcf5 into main Sep 3, 2024
57 of 58 checks passed
@bischofmax bischofmax deleted the BC-7894 branch September 3, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants