Docking: Fix DockBuilderRemoveNode() may cause read access violation. (…

…ocornut#3111)
hsimyu · Apr 29, 2020 · dd7cf83 · dd7cf83
1 parent 7ddc1ad
commit dd7cf83
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/imgui.cpp b/imgui.cpp
@@ -14183,6 +14183,12 @@ void ImGui::DockBuilderRemoveNode(ImGuiID node_id)
         return;
     DockBuilderRemoveNodeDockedWindows(node_id, true);
     DockBuilderRemoveNodeChildNodes(node_id);
+
+    // Check is node_id still available (#3111)
+    node = DockContextFindNodeByID(ctx, node_id);
+    if (node == NULL)
+        return;
+
     if (node->IsCentralNode() && node->ParentNode)
         node->ParentNode->LocalFlags |= ImGuiDockNodeFlags_CentralNode;
     DockContextRemoveNode(ctx, node, true);