Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RoutingProxy.prototype.remove #246

Merged
merged 1 commit into from
Jul 22, 2012

Conversation

tellnes
Copy link
Contributor

@tellnes tellnes commented May 17, 2012

Returns the proxy object so we can call the close method. Maybe it should be possible to set a flag that will automatically do it?

@coderarity
Copy link
Contributor

Maybe it should close it automatically and not return the proxy at all? I think that it's abstracting away the HttpProxy objects so it should continue to hide that complexity and close the proxy itself.

@tellnes
Copy link
Contributor Author

tellnes commented Jun 20, 2012

If I remove a proxy does not mean I want to end all active connections to the server. It just mean I want no more connections to the server.

@indexzero
Copy link
Contributor

lgtm.

indexzero added a commit that referenced this pull request Jul 22, 2012
Implement RoutingProxy.prototype.remove
@indexzero indexzero merged commit 02b914d into http-party:master Jul 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants