Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRLF character to end of multipart body. #17

Merged
merged 1 commit into from
Sep 17, 2017

Conversation

mhickman
Copy link

@mhickman mhickman commented Sep 14, 2017

Per RFC 1521 this character is required at the end of multipart body.

Per RFC 2046 there is an optional CRLF character at the end of the multipart-body to delimit between the body and optional epilogue.

Some server implementations break if this character is not added, so adding it here as it complies with both RFCs.

Per RFC 1521 this character is required at the end of multipart body.
Per RFC 2046 there is an optional CRLF character at the end
of the multipart-body to delimit between the body and optional
epilogue.

Some server implementations break if this character is
not added, so adding it here as it complies with both RFCs.
@ixti
Copy link
Member

ixti commented Sep 17, 2017

Awesome! Thanks!

@ixti ixti merged commit f2c856d into httprb:master Sep 17, 2017
@mhickman mhickman deleted the fix_clrf_ending_multipart branch September 19, 2017 17:09
@mhickman
Copy link
Author

@ixti - np! I've worked around this for the time being, but any idea of when it would be included in a new release?

@ixti
Copy link
Member

ixti commented Sep 20, 2017

@mhickman I'll do that ASAP. Latest - this weekend :D

@mhickman
Copy link
Author

Thanks!

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Dec 9, 2017
This version is required by newer ruby-http gem 3.0.0.

Upstream changes: (from CHANGES.md)

## 2.0.0 (2017-10-01)

* [#17](httprb/form_data#17)
  Add CRLF character to end of multipart body.
  [@mhickman][]


## 2.0.0.pre2 (2017-05-11)

* [#14](httprb/form_data#14)
  Enable streaming for urlencoded form data.
  [@janko-m][]


## 2.0.0.pre1 (2017-05-10)

* [#12](httprb/form_data#12)
  Enable form data streaming.
  [@janko-m][]
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Mar 17, 2018
## 2.1.0 (2018-03-05)

* [#21](httprb/form_data#21)
  Rewind content at the end of `Readable#to_s`.
  [@janko-m][]

* [#19](httprb/form_data#19)
  Fix buffer encoding.
  [@HoneyryderChuck][]


## 2.0.0 (2017-10-01)

* [#17](httprb/form_data#17)
  Add CRLF character to end of multipart body.
  [@mhickman][]


## 2.0.0.pre2 (2017-05-11)

* [#14](httprb/form_data#14)
  Enable streaming for urlencoded form data.
  [@janko-m][]


## 2.0.0.pre1 (2017-05-10)

* [#12](httprb/form_data#12)
  Enable form data streaming.
  [@janko-m][]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants