Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define Accept-CH-Lifetime #313

Merged
merged 2 commits into from
Mar 26, 2017
Merged

define Accept-CH-Lifetime #313

merged 2 commits into from
Mar 26, 2017

Conversation

igrigorik
Copy link
Member

Closes #307 and #306.

@igrigorik igrigorik requested a review from mnot March 17, 2017 22:28
This was referenced Mar 17, 2017
Closed
Closed
@mnot
Copy link
Member

mnot commented Mar 22, 2017

Looks good overall.

Accept-CH-Lifetime changes the semantics of Accept-CH. Not only does it effectively put Accept-CH on subsequent responses from the same origin for the given lifetime, it also suggests that Client Hints should be added to requests to that origin, no matter where the requesting page has come from.

Not a problem, but right now it's conveyed almost as an aside. This needs to be clearly specified so it isn't missed / misunderstood.

@igrigorik
Copy link
Member Author

@mnot updated, PTAL.

mnot
mnot approved these changes Mar 26, 2017
View reviewed changes
Copy link
Member

@mnot mnot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better.

@igrigorik
Copy link
Member Author

Thanks Mark!

@igrigorik igrigorik merged commit 8486ed5 into master Mar 26, 2017
@MikeBishop MikeBishop deleted the accept-ch-lifetime branch April 3, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnot mnot mnot approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igrigorik @mnot