-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-Hungarian network rules #398
Comments
I've collected the rules that seem problematic. I think it's enough to review these rules: Show rules||widget.block4d.com^
||a.adnium.com^
||adk2x.com^
||app.livechatoo.com^
||brostraffic.com^
||cdn-dynamic.optimonk.com^
||ctnsnet.com^
||et.twyn.com^
||fourtwentytradingcompany.net^
||fruitflan.com^
||iofferphoto.com^
||loading-delivery2.com^
||netadclick.com^
||netexs.com^
||new-bigpenn.com^
||pixel.sojern.com^
||rc.rootclick.com^
||redwolfmoon.com^
||smartcj.com^
||srv1.srv-stat.com^
||stat.adultium.com^
||stats.badoostats.com^
||syndication.trafficreps.com^
||up-banner.wavecdn.de^
||vid4u.org^
||wstat.ozon.ru^
||abmr.net^$third-party
||ad4mat.net^$third-party
||adfox.ru^$third-party
||ads.ventivmedia.com^$third-party
||advantage.as^$third-party
||advertshot.ru^$third-party
||betfair.com^$third-party
||bongacash.com^$third-party
||calivary.com^$third-party
||clickspromos.com^$third-party
||clicksure.com^$third-party
||head-clickfusion.com^$third-party
||iforex.com^$third-party
||iitech.dk^$third-party
||js.leadin.com^$third-party
||match.rundsp.com^$third-party
||megaclick.com/ad.code$third-party
||out.pladform.ru^$third-party
||playertise.com^$third-party
||po.st^$third-party
||pornedup.com^$third-party
||premads.info^$third-party
||salesmanago.pl^$third-party
||seedr.com^$third-party
||seedr.ru^$third-party
||shortlink.sex^$third-party
||streameye.net^$third-party
||sumome.com^$third-party
||tripod.com^$third-party
||tripod.lycos.com^$third-party
||tulajdonostol.com^$third-party
||xxxshort.com^$third-party
||counter.megagroup.ru^
||track.trackbyme.info^
||tracker.azet.sk^
||tracking.binarypromos.com^
||zanox.com^
||analytics.yahoo.com^$third-party
||counter.hitslink.com^$third-party
||ex1tp.com^$third-party
||google-analytics.com^$third-party
||gravity.com^$third-party
||lo.v.liveperson.net^$third-party
||onesignal.com^$third-party
||targetix.net^$third-party
||track306.info^$third-party
||trackingterrorism.org^$third-party
||va.v.liveperson.net^$third-party,script Questions:
|
I see a problem here. If a filter rule is only available in one international list, and we remove the said rule from hufilter, then many people won't benefit from it. For example, I think we have to find a workaround for this case. Maybe we can:
Or
Please note that this problem only applies to rules which can cause issues on non-hungarian sites, since if there's a rule that only cause issues on Hungarian sites, then they don't have to be moved to international lists. This might be relevant for a few rules only though, so let me know what you think @scripthunter7 |
In this case I think we should open a PR to EasyList / EasyPrivacy
|
Redundant rules: EasyList:
AG Base:
What I suggest at first glance:
CC @ehrhardt06 |
Will do. |
@ehrhardt06 In the next step, we should categorize the rules from my previous comment. Suggested workflow:
In the first round, please don't open any PR to hufilter or EasyList, just categorize the rules into these 3 categories. Example: ! Category #2
||widget.block4d.com^
! ... If you have free time and can deal with this, thank you in advance :) |
I have checked few domains yesterday:
|
We try to avoid redundant rules in hufilter, but while the situation with ads is pretty clear (the whole thing is based on EasyList), the annoyance filters are quite different. Since hufilter supports many adblockers, it is difficult to tell exactly what anti-annoyance filters are used by our users, so we currently use quite specific rules in our annoyances section. Something needs to be figured out for annoyances in the future, but for now what I recommend is to simply move this Edit: It seems this chat widget used by a lot of different sites, maybe it would be better to open a PR for it in Fanboy Annoyances |
Added a few rules to @AdamWr's previous list. It's not that organized though, forgive me. Show rules
! Category #1
||ctnsnet.com^ - blocked by EasyList/Base filter and probably dead
||brostraffic.com^ - probably can be removed
||cdn-dynamic.optimonk.com^ - probably can be removed
||fourtwentytradingcompany.net^ - probably obsolete
||loading-delivery2.com^ - probably obsolete
||track.trackbyme.info^ - probably dead
||tracker.azet.sk^ - probably can be removed
||head-clickfusion.com^$third-party - blocked by AG, will probably be covered by Easylist as well
||vid4u.org^ - blocked by AG, will probably be covered by Easylist as well
||clickspromos.com^$third-party - probably dead
||tulajdonostol.com^$third-party - probably dead
!
! Category #2
||widget.block4d.com^ - seems to be used mainly on Hungarian websites - https://publicwww.com/websites/%22widget.block4d.com%22/
||netadclick.com^ - seems to be used mainly on Hungarian websites - https://publicwww.com/websites/%22netadclick.com%22/
||netexs.com^ - seems to be used mainly on Hungarian websites - https://publicwww.com/websites/%22netexs.com%22/
||netadclick.com^ - Confirmed Hungarian adserver - https://publicwww.com/websites/%22netadclick.com%22/
||ex1tp.com^$third-party - seems to be used mainly on Hungarian websites - https://publicwww.com/websites/%22ex1tp.com%22/
!
! Category #3
||a.adnium.com^ - blocked by EasyList/Base filter
||adk2x.com^ - blocked by EasyList/Base filter
||betfair.com^$third-party - blocked by EasyList as ||ads.betfair.com^
||iforex.com^$third-party - not blocked / PR might be needed to EasyList/Base filter
||clicksure.com^$third-party - not blocked / PR might be needed to EasyList/Base filter
||onesignal.com^$third-party - blocked by EasyPrivacy/AG Tracking filter with varying rules
||google-analytics.com^$third-party - blocked by EasyPrivacy/AG Tracking filter with varying rules/Base filter
!
! Not sure which category
||app.livechatoo.com^ - blocked by AdGuard Annoyances filter (chat widget)
!
|
These still remain, I'll check some if I'll have more time. Show rules
||et.twyn.com^
||fruitflan.com^
||iofferphoto.com^
||new-bigpenn.com^
||pixel.sojern.com^
||rc.rootclick.com^
||redwolfmoon.com^
||smartcj.com^
||srv1.srv-stat.com^
||stat.adultium.com^
||stats.badoostats.com^
||syndication.trafficreps.com^
||up-banner.wavecdn.de^
||wstat.ozon.ru^
||abmr.net^$third-party
||ad4mat.net^$third-party
||adfox.ru^$third-party
||ads.ventivmedia.com^$third-party
||advantage.as^$third-party
||advertshot.ru^$third-party
||bongacash.com^$third-party
||calivary.com^$third-party
||iitech.dk^$third-party
||js.leadin.com^$third-party
||match.rundsp.com^$third-party
||megaclick.com/ad.code$third-party
||out.pladform.ru^$third-party
||playertise.com^$third-party
||po.st^$third-party
||pornedup.com^$third-party
||premads.info^$third-party
||salesmanago.pl^$third-party
||seedr.com^$third-party
||seedr.ru^$third-party
||shortlink.sex^$third-party
||streameye.net^$third-party
||sumome.com^$third-party
||tripod.com^$third-party
||tripod.lycos.com^$third-party
||xxxshort.com^$third-party
||counter.megagroup.ru^
||tracking.binarypromos.com^
||zanox.com^
||analytics.yahoo.com^$third-party
||counter.hitslink.com^$third-party
||gravity.com^$third-party
||lo.v.liveperson.net^$third-party
||targetix.net^$third-party
||track306.info^$third-party
||trackingterrorism.org^$third-party
||va.v.liveperson.net^$third-party,script |
Here is an updated list: Show checked rules
! Category #1
||ctnsnet.com^ - blocked by EasyList/Base filter and probably dead
||brostraffic.com^ - probably can be removed
||cdn-dynamic.optimonk.com^ - probably can be removed
||fourtwentytradingcompany.net^ - probably obsolete
||loading-delivery2.com^ - probably obsolete
||track.trackbyme.info^ - probably dead
||tracker.azet.sk^ - probably can be removed
||head-clickfusion.com^$third-party - blocked by AG, will probably be covered by Easylist as well
||vid4u.org^ - blocked by AG, will probably be covered by Easylist as well
||clickspromos.com^$third-party - probably dead
||tulajdonostol.com^$third-party - probably dead
||track306.info^$third-party - probably can be removed
||advertshot.ru^$third-party - probably can be removed
!
! Category #2
||widget.block4d.com^ - seems to be used mainly on Hungarian websites - https://publicwww.com/websites/%22widget.block4d.com%22/
||netadclick.com^ - seems to be used mainly on Hungarian websites - https://publicwww.com/websites/%22netadclick.com%22/
||netexs.com^ - seems to be used mainly on Hungarian websites - https://publicwww.com/websites/%22netexs.com%22/
||netadclick.com^ - Confirmed Hungarian adserver - https://publicwww.com/websites/%22netadclick.com%22/
||ex1tp.com^$third-party - seems to be used mainly on Hungarian websites - https://publicwww.com/websites/%22ex1tp.com%22/
!
! Category #3
||a.adnium.com^ - blocked by EasyList/Base filter
||adk2x.com^ - blocked by EasyList/Base filter
||betfair.com^$third-party - blocked by EasyList as ||ads.betfair.com^
||iforex.com^$third-party - not blocked
||clicksure.com^$third-party - not blocked / PR might be needed to EasyList/Base filter
||onesignal.com^$third-party - blocked by EasyPrivacy/AG Tracking filter with varying rules
||google-analytics.com^$third-party - blocked by EasyPrivacy/AG Tracking filter with varying rules/Base filter
||gravity.com^$third-party - not blocked (also redirects to gravitforms.com)
||analytics.yahoo.com^$third-party - blocked by EasyPrivacy/AG Tracking filter
||counter.hitslink.com^$third-party - blocked by EasyPrivacy/AG Tracking filter
||tracking.binarypromos.com^ - not blocked
||counter.megagroup.ru^ - blocked by EasyPrivacy
||lo.v.liveperson.net^$third-party - not blocked
||va.v.liveperson.net^$third-party,script - not blocked
||trackingterrorism.org^$third-party - not blocked
||tripod.com^$third-party - blocked by Peter Lowe's list
||tripod.lycos.com^$third-party - blocked by Peter Lowe's list
||megaclick.com/ad.code$third-party - not blocked
||adfox.ru^$third-party - blocked by Peter Lowe's list/EasyPrivacy/AG Tracking filter
||abmr.net^$third-party - blocked by EasyPrivacy/AG Tracking filter
||ad4mat.net^$third-party - blocked by Peter Lowe's list
||advantage.as^$third-party - blocked by AG Base
||ads.ventivmedia.com^$third-party - Peter Lowe's list/EasyPrivacy/AG Tracking filter
!
! Not sure which category
||app.livechatoo.com^ - blocked by AdGuard Annoyances filter (chat widget)
||zanox.com^ - already removed from hufilter
||shortlink.sex^$third-party
!
And these still have to be checked: Show remaining rules
||et.twyn.com^
||fruitflan.com^
||iofferphoto.com^
||new-bigpenn.com^
||pixel.sojern.com^
||rc.rootclick.com^
||redwolfmoon.com^
||smartcj.com^
||srv1.srv-stat.com^
||stat.adultium.com^
||stats.badoostats.com^
||syndication.trafficreps.com^
||up-banner.wavecdn.de^
||wstat.ozon.ru^
||bongacash.com^$third-party
||calivary.com^$third-party
||iitech.dk^$third-party
||js.leadin.com^$third-party
||match.rundsp.com^$third-party
||out.pladform.ru^$third-party
||playertise.com^$third-party
||po.st^$third-party
||pornedup.com^$third-party
||premads.info^$third-party
||salesmanago.pl^$third-party
||seedr.com^$third-party
||seedr.ru^$third-party
||streameye.net^$third-party
||sumome.com^$third-party
||xxxshort.com^$third-party
||targetix.net^$third-party I'll check back a few days later if the rest is not already categorized |
@scripthunter7 Here are the sorted rules, all of them. Sorry for the delay. Show rules
! Category #1
||advertshot.ru^$third-party - probably can be removed
||brostraffic.com^ - probably can be removed
||calivary.com^$third-party - probably can be removed
||cdn-dynamic.optimonk.com^ - probably can be removed
||clickspromos.com^$third-party - probably dead
||ctnsnet.com^ - blocked by EasyList/Base filter and probably dead
||fourtwentytradingcompany.net^ - probably obsolete
||fruitflan.com^ - dead
||iitech.dk^$third-party - probably dead
||iofferphoto.com^ - probably can be removed
||js.leadin.com^$third-party - probably can be removed
||loading-delivery2.com^ - probably obsolete
||new-bigpenn.com^ - probably can be removed
||out.pladform.ru^$third-party - probably can be removed
||playertise.com^$third-party - probably dead
||po.st^$third-party - probably can be removed
||pornedup.com^$third-party - probably can be removed
||premads.info^$third-party - probably can be removed
||redwolfmoon.com^ - probably can be removed
||seedr.com^$third-party - probably can be removed
||seedr.ru^$third-party - probably can be removed
||smartcj.com^ - probably can be removed
||srv1.srv-stat.com^ - probably can be removed
||stats.badoostats.com^ - probably can be removed
||streameye.net^$third-party - probably can be removed
||track.trackbyme.info^ - probably dead
||track306.info^$third-party - probably can be removed
||tracker.azet.sk^ - probably can be removed
||tulajdonostol.com^$third-party - probably dead
||up-banner.wavecdn.de^ - dead
||vid4u.org^ - blocked by AG, will probably be covered by Easylist as well
||xxxshort.com^$third-party - probably can be removed
!
! Category #2
||ex1tp.com^$third-party - seems to be used mainly on Hungarian websites - https://publicwww.com/websites/%22ex1tp.com%22/
||netadclick.com^ - Confirmed Hungarian adserver - https://publicwww.com/websites/%22netadclick.com%22/
||netadclick.com^ - seems to be used mainly on Hungarian websites - https://publicwww.com/websites/%22netadclick.com%22/
||netexs.com^ - seems to be used mainly on Hungarian websites - https://publicwww.com/websites/%22netexs.com%22/
||rc.rootclick.com^ - seems to be used mainly on Hungarian websites
||widget.block4d.com^ - seems to be used mainly on Hungarian websites - https://publicwww.com/websites/%22widget.block4d.com%22/
!
! Category #3
||a.adnium.com^ - blocked by EasyList/Base filter
||abmr.net^$third-party - blocked by EasyPrivacy/AG Tracking filter
||ad4mat.net^$third-party - blocked by Peter Lowe's list
||adfox.ru^$third-party - blocked by Peter Lowe's list/EasyPrivacy/AG Tracking filter
||adk2x.com^ - blocked by EasyList/Base filter
||ads.ventivmedia.com^$third-party - Peter Lowe's list/EasyPrivacy/AG Tracking filter
||advantage.as^$third-party - blocked by AG Base
||analytics.yahoo.com^$third-party - blocked by EasyPrivacy/AG Tracking filter
||betfair.com^$third-party - blocked by EasyList as ||ads.betfair.com^
||bongacash.com^$third-party - blocked by Peter Lowe's list
||clicksure.com^$third-party - not blocked / PR might be needed to EasyList/Base filter
||counter.hitslink.com^$third-party - blocked by EasyPrivacy/AG Tracking filter
||counter.megagroup.ru^ - blocked by EasyPrivacy
||et.twyn.com^ - blocked by Peter Lowe's list
||google-analytics.com^$third-party - blocked by EasyPrivacy/AG Tracking filter with varying rules/Base filter
||gravity.com^$third-party - not blocked (also redirects to gravitforms.com)
||iforex.com^$third-party - not blocked
||lo.v.liveperson.net^$third-party - not blocked
||match.rundsp.com^$third-party - blocked by Peter Lowe's list
||megaclick.com/ad.code$third-party - not blocked
||onesignal.com^$third-party - blocked by EasyPrivacy/AG Tracking filter with varying rules
||pixel.sojern.com^ - blocked by Peter Lowe's list & AG tracking
||salesmanago.pl^$third-party - ||salesmanago.pl/api/r.gif blocked by AG tracking list
||stat.adultium.com^ - adultium.com blocked by EasyPrivacy
||sumome.com^$third-party - blocked by Peter Lowe's list
||syndication.trafficreps.com^ - blocked by AG mobile filter
||targetix.net^$third-party - blocked by EasyPrivacy
||tracking.binarypromos.com^ - not blocked
||trackingterrorism.org^$third-party - not blocked
||tripod.com^$third-party - blocked by Peter Lowe's list
||tripod.lycos.com^$third-party - blocked by Peter Lowe's list
||va.v.liveperson.net^$third-party,script - not blocked
||wstat.ozon.ru^ - blocked by AG tracking
!
! Not sure which category
||app.livechatoo.com^ - blocked by AdGuard Annoyances filter (chat widget)
||shortlink.sex^$third-party
||zanox.com^ - already removed from hufilter
!
|
@ehrhardt06 Thank you for doing this! Time for a new PR? :) btw you can open separate PRs according to the categories, maybe that would be better |
Over the years, many network rules have been added to hufilter, which target non-Hungarian websites, for example
||adfox.ru^$third-party
, etc. At first glance, I think many of these rules fit into an international filter (like AG Base List or EasyList) instead of our language-specific filter (if the domain is still alive at all of course, as these are several years old rules).The main purpose of our list is to supplement international lists, so if possible we should avoid rules that go beyond the purposes of our language-specific filter.
Affected sections:
hufilter-dev/sections/ads.txt
Lines 1378 to 1488 in fd5ac98
hufilter-dev/sections/trackers.txt
Lines 15 to 47 in fd5ac98
CC @ehrhardt06 @Alex-302 @AdamWr What do you think?
The text was updated successfully, but these errors were encountered: