Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dynamicrafter library #804

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

NielsRogge
Copy link
Contributor

@NielsRogge NielsRogge commented Jul 16, 2024

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Same comment as in #805 (review), it would be cool to add text-to-video and image-to-video tags in models on the Hub. For what I understand DynamiCrafter_512_Interp is only image-to-video but other repos can do both? In that case, you can tag them like ali-vilab/i2vgen-xl

packages/tasks/src/model-libraries-snippets.ts Outdated Show resolved Hide resolved
packages/tasks/src/model-libraries.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Same as #804 (review), it would be cool to have pipeline_tag in the Hub PRs + get them merged before merging this one :)

packages/tasks/src/model-libraries.ts Outdated Show resolved Hide resolved
Copy link
Member

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given the open comments 👍

@NielsRogge
Copy link
Contributor Author

Thanks, I've updated the PRs, have to say that the workflow to do this is pretty hard, not easy to find.

It's only documented here how you can manage and update a PR locally which you've opened on the web interface.

I'm in contact with the Dynamicrafter author on Slack and will wait for him to merge the PRs above before merging this one.

@Wauplin
Copy link
Contributor

Wauplin commented Jul 18, 2024

Thanks for updating the PRs! This will prove useful! Let us know once it's merged 😃

I've updated the PRs, have to say that the workflow to do this is pretty hard, not easy to find.

It's only documented here how you can manage and update a PR locally which you've opened on the web interface.

Arf yes, what I usually do is to use the browser to navigate through the file on the PR ref revision, select the file I want to edit and edit it. In the example below I don't have the edit button because it's not my PR but you see the idea.

Screencast.from.18-07-2024.16.28.54.webm

@Wauplin
Copy link
Contributor

Wauplin commented Jul 18, 2024

Regarding the PRs, I think that https://huggingface.co/Doubiiu/DynamiCrafter_512_Interp/discussions/1/files should be image-to-video IIUC. And https://huggingface.co/Doubiiu/DynamiCrafter_1024/discussions/1/files, https://huggingface.co/Doubiiu/DynamiCrafter_512/discussions/1/files, https://huggingface.co/Doubiiu/DynamiCrafter/discussions/3/files should have text-to-video as pipeline_tag and image-to-video in tags since they support both (to confirm with the repo owner)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants