-
Notifications
You must be signed in to change notification settings - Fork 26.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix attn mask ignore logic in training-time trace #32613
Open
zhenglongjiepheonix
wants to merge
15
commits into
huggingface:main
Choose a base branch
from
zhenglongjiepheonix:zlj/enable_compile_tracing_for_training
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+55
−5
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5397d83
fix attn mask logic for training-time trace
zhenglongjiepheonix 3ef2037
add test
zhenglongjiepheonix 0322f81
fix
zhenglongjiepheonix a87e981
Merge remote-tracking branch 'upstream/main' into zlj/enable_compile_…
zhenglongjiepheonix 02fd2fa
fix
zhenglongjiepheonix bb7f36e
fix
zhenglongjiepheonix 569a9af
fix
zhenglongjiepheonix 12a3649
fix
zhenglongjiepheonix 2252397
format
zhenglongjiepheonix 53b7c6c
Merge remote-tracking branch 'upstream/main' into zlj/enable_compile_…
zhenglongjiepheonix f1d1fa1
Merge remote-tracking branch 'upstream/main' into zlj/enable_compile_…
zhenglongjiepheonix 18778c0
[run-slow] llama
zhenglongjiepheonix 55219dd
Merge remote-tracking branch 'upstream/main' into zlj/enable_compile_…
zhenglongjiepheonix 4f030ff
avoid accelearate
zhenglongjiepheonix c649ff1
[run-slow] llama
zhenglongjiepheonix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually a paradox branch where
is_tracing
andtorch.all(attention_mask == 1)
can never exist together