Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[whisper] Clarify error message when setting max_new_tokens #33324

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

benniekiss
Copy link
Contributor

What does this PR do?

This PR clarifies the error message returned when the length of the prompt tokens + max_new_tokens exceeds the max_target_positions of the whisper model.

Addresses the discussion in #32571

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ylacombe

@ylacombe
Copy link
Contributor

ylacombe commented Sep 12, 2024

Thanks for opening this PR @benniekiss !
There's weirdly a Whisper failing test. Would you like to first rebase the PR branch, and then we'll see what we can do if it's still there ?

@benniekiss
Copy link
Contributor Author

the failing test is here

It seems that the old error message is hardcoded in the test. Should I go ahead and update it to the new message so they are in sync?

@ylacombe
Copy link
Contributor

Oh right, let's do this! It's a bit weird indeed, but let's just correct the test

Copy link
Contributor

@ylacombe ylacombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge once it's all green ! Thanks for iterating !

@benniekiss
Copy link
Contributor Author

ofc! pleasure working with yall

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ylacombe ylacombe merged commit 5c6257d into huggingface:main Sep 12, 2024
18 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants