fix: fix default base as per URL spec #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomrdias
approved these changes
Oct 21, 2020
hugomrdias
changed the title
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value set for
basewas causing issues in environments such as React Native where.locationdoes not exist. Furthermore, whenbaseis unspecified the default value should beundefinedinstead of an empty string.I'm assuming
package-lock.jsonshould be ignored considering it was not previously committed. As such, I've added it to the ignore file.I wasn't really sure how to go about testing this change. AFAIK, it's not possible to remove
locationfromwindowas Playwright/Chromium complains if I try delete it. The hack I came up with is to construct the browser URL in Node to simulate a React Native-like environment withoutlocation. Truth to be told, I don't like this approach but this is what we can get away with for the time being to ensure a regression is not introduced.What do you think @hugomrdias?
This PR aims to fix ipfs/js-ipfs#3332.