Completion callback improvements #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompletion (when content is really posted to social network). Fixed Mail and Messages image attachments. Using PNG attachment where possible.
|
Hey @virl I think you've pull the wrong repo.. I'm already forking the original repo. you should submit to the original repo. But you're request seem awesome! |
|
@huguesbr anyway, please accept this pull request, because original repo still not accepted your own pull request. |
|
I've created pull request to original repository, but please accept to yours too. |
huguesbr
added a commit
that referenced
this pull request
Mar 6, 2014
Completion callback improvements
|
got it.. accepted |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing completion block called with success only upon real sharing completion (when content is really posted to social network).
Fixed Mail and Messages image attachments.
Using PNG attachment where possible.
Fixed activityType names for non-system activities.