Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Transit engine? #302

Closed
alexandernst opened this issue Oct 26, 2018 · 4 comments
Closed

Support for Transit engine? #302

alexandernst opened this issue Oct 26, 2018 · 4 comments
Labels
secrets engines generally related to a Vault secrets engine transit Transit secrets engine
Milestone
0.7.1

Comments

@alexandernst
Copy link
Contributor

Are there any plans to support Transit engine?
@jeffwecan
Copy link
Member

We're looking to implement explicit support for all available Vault API routes at some point. So generally, yes. :P

I can move Transit towards the top of the backlog though!

@jeffwecan jeffwecan added secrets engines generally related to a Vault secrets engine transit Transit secrets engine labels Oct 26, 2018
@jeffwecan jeffwecan added this to the 0.7.1 milestone Oct 26, 2018
@alexandernst
Copy link
Contributor Author

Yes, please! We're looking towards using Transit. In fact, we'd like to contribute if that will speed up things.

@jeffwecan
Copy link
Member

Feel free to contribute whatever you'd like; that is always very appreciated! Unfortunately, we don't have a great contributing doc around adding new classes along these lines at the moment. However using recent PRs like #244 or #257 as examples would hopefully provide enough of a framework to get started with.

I also have a work-in-progress script to stub out hvac classes based on vaultproject.io documentation. So if you want to use the output of that script as a launching off point, check out this branch on my fork: https://github.com/hvac/hvac/compare/master...jeffwecan:transit_secret_engine_class?expand=1

@alexandernst alexandernst mentioned this issue Oct 28, 2018
Merged
jeffwecan pushed a commit that referenced this issue Oct 31, 2018
@alexandernst @jeffwecan
[WIP] Implement Transit engine (#302) (#303)
6221123 
* Initial commit

* Make the thing actually "compile"

* Make create_key work + verify pydocs

* Make read_key work + verify pydocs

* Make list_keys work + verify pydocs

* Don't split list_keys pydocs on two lines

* We don't need to pass name in the payload

* Make delete_key work + verify pydocs

* Make update_key_configuration work + verify pydocs

* Make rotate_key work + verify pydocs

* Make export_key work + verify pydocs

* Make encrypt_data work + verify pydocs

* Make decrypt_data work + verify pydocs

* Make rewrap_data work + verify pydocs

* Make generate_data_key work + verify pydocs

* Make generate_random_bytes work + verify pydocs

* Make hash_data work + verify pydocs

* Make generate_hmac work + verify pydocs

* Make sign_data work + verify pydocs

* Make verify_signed_data work + verify pydocs

* Make backup_key work + verify pydocs

* Make restore_key work + verify pydocs

* Make trim_key work + verify pydocs

* Deprecate old methods

* Delete unit tests

* Make linter happy again

* Fill in transit docs

* Fill in transit tests

* Finish transit implementation

* remove stray Exception rasin

* skip expore/restore tests for Vault vers <0.9.1

* fix sources of flake8 complaints

* Skipif needed on test_export_key as well
@jeffwecan
Copy link
Member

Closed by #303.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
secrets engines generally related to a Vault secrets engine transit Transit secrets engine
Projects
None yet
Milestone
0.7.1
Development

No branches or pull requests
2 participants
@alexandernst @jeffwecan