Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panicking following 0.3.17 #674

Closed
Noah-Kennedy opened this issue Apr 15, 2023 · 1 comment · Fixed by #676
Closed

Panicking following 0.3.17 #674

Noah-Kennedy opened this issue Apr 15, 2023 · 1 comment · Fixed by #676

Comments

@Noah-Kennedy
Copy link
Contributor

It would seem that the patch brought forth some issues.

We panic at

h2/src/proto/streams/streams.rs

Line 146 in af4bcac

me.counts.dec_num_remote_reset_streams();
, causing us to panic again at https://github.com/hyperium/h2/blob/master/src/proto/streams/streams.rs#L1359.
@Noah-Kennedy
Copy link
Contributor Author

I'll try and mess more with this tomorrow

@seanmonstar seanmonstar mentioned this issue Apr 17, 2023
Merged
hawkw added a commit to linkerd/linkerd2-proxy that referenced this issue Apr 18, 2023
@hawkw
build(deps): bump h2 to v0.3.18
a091f97 
The DOS mitigation changes in `h2` v0.3.17 inadvertantly introduced a
potential panic (hyperium/h2#674). Version 0.3.18 fixes this, so we
should bump the proxy's dependency to avoid panics.
@hawkw hawkw mentioned this issue Apr 18, 2023
Merged
hawkw added a commit to linkerd/linkerd2-proxy that referenced this issue Apr 18, 2023
@hawkw
build(deps): bump h2 to v0.3.18 (#2394)
051e0e1 
The DOS mitigation changes in `h2` v0.3.17 inadvertantly introduced a
potential panic (hyperium/h2#674). Version 0.3.18 fixes this, so we
should bump the proxy's dependency to avoid panics.
dae added a commit to ankitects/anki that referenced this issue Apr 19, 2023
@dae
Bump h2 version
1ff27b4 
hyperium/h2#674
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pending-accept remotely-reset streams pattern was checking is_local hyperium/h2
1 participant
@Noah-Kennedy