Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change a debug_assert to assert #613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change a debug_assert to assert #613

wants to merge 1 commit into from

Conversation

nox
Copy link
Contributor

@nox nox commented May 2, 2022

This is already asserted a few lines later anyway when calling self.flow.send_data(len) in the "updating connection flow" span.

This is already asserted a few lines later anyway
when calling `self.flow.send_data(len)` in the
"updating connection flow" span.
@seanmonstar
Copy link
Member

By making this change, is it catching a bug and triggering a panic?

@nox
Copy link
Contributor Author

nox commented May 5, 2022

It's changing a panic a bit. I'm trying to debug a bug we have at work about the assertion self.window_size >= sz as usize in FlowControl::send_data as described in #607. AFAIK this is the same as this debug_assert.

kriswuollett pushed a commit to appbiotic/h2 that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants