Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PollExt trait #625

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Conversation

kckeiks
Copy link
Contributor

@kckeiks kckeiks commented Jul 18, 2022

Hello,
Rust #63512 was stabilized so this PR removes the PollExt trait.

@seanmonstar
Copy link
Member

Thanks for the PR! It looks like the MSRV job is failing (I've fixed that on master), care to rebase? When did the methods stabilize? We try to keep the MSRV at least 6 months old, and prefer to only upgrade when there's a decent improvement.

Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
@kckeiks
Copy link
Contributor Author

kckeiks commented Jul 18, 2022

@seanmonstar They were stabilized on January of 2021 (rust-lang/rust#80968).

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you :)

@seanmonstar seanmonstar merged commit 756384f into hyperium:master Jul 18, 2022
Abhinandan-Purkait pushed a commit to openebs/h2 that referenced this pull request May 8, 2024
Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
Abhinandan-Purkait pushed a commit to openebs/h2 that referenced this pull request May 8, 2024
Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
Abhinandan-Purkait pushed a commit to openebs/h2 that referenced this pull request May 8, 2024
Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
Abhinandan-Purkait pushed a commit to openebs/h2 that referenced this pull request May 9, 2024
Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants