#3000: Serialize debug_data when present in GOAWAY frames #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hyperium/hyper#3200
Debug data in GOAWAY frames is opaque information meant for diagnostic purposes. The data was previously read and stored when being received, but was never written during encoding.
This pull request includes the data when encoding the frame but does not add a (stable) way of setting the data. If it is desired I am happy to include it too. I suspect the function added for testing purposes wouldn't be fit for a stable, public API.
Additionally, I've included an integration test as described in the original issue. However, I'm quite sure there is a better way of creating the GOAWAY frame, I'm just not familiar enough with the structure of the integration tests to find it at the moment. With a few pointers I'd like to rewrite how it is done, if needed.