Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back max_pending_accept_reset_streams #78

Closed
wants to merge 2 commits into from

Conversation

allan2
Copy link
Contributor

@allan2 allan2 commented Dec 12, 2023

Adds back this function which was previously in hyper 0.14.

The original merge into hyper is
here

This follows the original closely, with some minor wording improvements in the outer line docs.

Closes hyperium/hyper#3461.

@allan2
Copy link
Contributor Author

allan2 commented Dec 12, 2023

I updated the version to 0.1.2, possibly prematurely. This function is used by tonic so I'd like to have it for the tonic hyper 1.0 update :)

Cargo.toml Outdated Show resolved Hide resolved
This function was in 0.14 but missed in 1.0.

The original function was merged [here](https://github.com/hyperium/hyper/pull/3201/files/e8296d1c5bded88a508f1ca1f35791c30803182d)
This commit simply copies directly from it.

The config part has been merged into hyper 1.0 (hyperium/hyper#3507).
This commit completes the re-addition of this missing function.
@allan2
Copy link
Contributor Author

allan2 commented Jan 3, 2024

Hi @seanmonstar, I've synced and updated this PR.

With hyperium/hyper#3507, this should complete the re-addition of this function.

@ikrivosheev
Copy link

#90 was merged, we can close this PR.

@allan2
Copy link
Contributor Author

allan2 commented Feb 29, 2024

Superseded by #90 (merged) and #102

@allan2 allan2 closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hyper-util missing max_pending_accept_reset_streams
3 participants