Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typescript definitions for t function without namespaces #1214

Merged
merged 7 commits into from
Dec 8, 2020

Conversation

pedrodurek
Copy link
Member

@pedrodurek pedrodurek commented Dec 8, 2020

Fix bugs: #1213 and #1212

In addition, I also added two examples of use and included the reference in the README file. Moreover, now that prettier is supporting typescript 4.1 (prettier/prettier#9234) I also bumped the prettier version and run it on type definitions file.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • documentation is changed or added

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.692% when pulling ab25221 on pedrodurek:master into a4aaf65 on i18next:master.

@Thanaen
Copy link

Thanaen commented Dec 8, 2020

Hi !
I've tried to apply the new TS 4.1 example, but it seems to break when a there is a key named "keys" in the translations file :-(
Here is a simple repo I used to reproduce this issue. Simply clone it, do 'yarn' then 'yarn lint' / 'yarn start' !
Here is the repository: https://github.com/Thanaen/repro-react-i18n-ts-bug

@jamuhl jamuhl merged commit a7f825f into i18next:master Dec 8, 2020
@jamuhl
Copy link
Member

jamuhl commented Dec 8, 2020

@Thanaen this looks like a different issue?!? My suggestion would be creating a new issue for that and mentioning @pedrodurek

@Thanaen
Copy link

Thanaen commented Dec 8, 2020

@jamuhl Okay, creating a new issue ! Thanks for your suggestion 👍

@jamuhl
Copy link
Member

jamuhl commented Dec 8, 2020

was published in react-i18next@11.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants