Fix allow to replace i18n in provider with useTranslation hook (#1272) #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrai
reviewed
Mar 6, 2021
| }; | ||
| }, [namespaces.join()]); // re-run effect whenever list of namespaces changes | ||
|
|
||
| const isInitial = useRef(true); |
There was a problem hiding this comment.
Can you maybe add an inline comment to explain why this is needed?
For future generations ;-)
|
lgtm |
|
thanks to all participating in this fix was published in react-i18next@11.8.9 |
This was referenced Mar 9, 2021
This was referenced Mar 13, 2021
Closed
Closed
Closed
This was referenced Mar 15, 2021
This was referenced Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Prettier seems to be run on committed files as part of the pre-commit husky hook and did some little code changes in useTranslation.js, not my fault ;-)
npm run test-- No need for documentation update