Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes #1284

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Bug fixes #1284

merged 2 commits into from
Mar 24, 2021

Conversation

pedrodurek
Copy link
Member

Fix both issues reported: #1281 and #1277

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • documentation is changed or added

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.205% when pulling 9aedf85 on pedrodurek:master into 228c55f on i18next:master.

@pedrodurek
Copy link
Member Author

Hey @jamuhl, can we merge these fixes?

@adrai
Copy link
Member

adrai commented Mar 23, 2021

lgtm

@jamuhl jamuhl merged commit f9bfd55 into i18next:master Mar 24, 2021
@jamuhl
Copy link
Member

jamuhl commented Mar 24, 2021

was published in react-i18next@11.8.11

This was referenced Nov 25, 2023
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pedrodurek @coveralls @adrai @jamuhl