Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transWrapTextNodes option #1324

Merged
merged 2 commits into from
May 28, 2021
Merged

Add transWrapTextNodes option #1324

merged 2 commits into from
May 28, 2021

Conversation

feross
Copy link
Contributor

@feross feross commented May 27, 2021

The transWrapTextNodes option instructs react-i18next to wrap text nodes in a user-specified element. By default, text nodes are not wrapped.

Fixes: #1323

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • documentation is changed or added

The `transWrapTextNodes` option instructs react-i18next to wrap text nodes in a user-specified element. By default, text nodes are not wrapped.

Fixes: #1323
@coveralls
Copy link

coveralls commented May 27, 2021

Coverage Status

Coverage increased (+0.02%) to 96.583% when pulling 09d4be5 on feross:wrap into 39ce5a9 on i18next:master.

@feross
Copy link
Contributor Author

feross commented May 27, 2021

The codeclimate failure is unrelated to the code I added.

@adrai
Copy link
Member

adrai commented May 28, 2021

lgtm

would be nice to have at least 1 test

@adrai
Copy link
Member

adrai commented May 28, 2021

lgtm

would be nice to have at least 1 test

Just added a simple test ;-)

@adrai adrai merged commit 931f619 into i18next:master May 28, 2021
@adrai
Copy link
Member

adrai commented May 28, 2021

included with v11.10.0

@adrai
Copy link
Member

adrai commented May 28, 2021

@feross feross deleted the wrap branch May 28, 2021 19:58
@feross
Copy link
Contributor Author

feross commented May 28, 2021

Amazing – thanks for the quick merge and release!

@adrai
Copy link
Member

adrai commented May 28, 2021

thx for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Proposal: Trans prop to wrap text nodes in a user-specified element
3 participants