Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type-safe support to keyPrefix option #1390

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

pedrodurek
Copy link
Member

Closes #1387

I've performed some tests and thankfully we won't have a significant increase in compilation time 🎉 .

I'll also update our documentation soon!

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.057% when pulling a145b31 on pedrodurek:support-key-prefix-option into 791957d on i18next:master.

@pedrodurek pedrodurek requested a review from adrai October 28, 2021 07:28
@pedrodurek
Copy link
Member Author

It shouldn't have any breaking changes

@adrai
Copy link
Member

adrai commented Oct 28, 2021

I'm not a TypeScript user, so if it looks good for you, it looks good for me ;-)
btw: keyPrefix is an i18next core feature (https://www.i18next.com/overview/api#getfixedt), so maybe it also needs some types updates in i18next?
do you want me to merge?

@pedrodurek
Copy link
Member Author

Hey @adrai, until we move the type-safe feature to the i18next lib, we can safely merge this one

@adrai adrai merged commit 008d1b0 into i18next:master Oct 28, 2021
@adrai
Copy link
Member

adrai commented Oct 28, 2021

Should we wait to release a new version until #1367 gets done?

@pedrodurek
Copy link
Member Author

Actually, #1367 is good to go

@adrai
Copy link
Member

adrai commented Oct 28, 2021

included in v11.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type-safe translations do not work with keyPrefix
3 participants