Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type support to plurals #1399

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Add type support to plurals #1399

merged 2 commits into from
Nov 9, 2021

Conversation

pedrodurek
Copy link
Member

@pedrodurek pedrodurek commented Nov 9, 2021 •
edited
Loading

Closes #1386 and i18next/i18next#1683

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.057% when pulling 82f19d7 on pedrodurek:support-plurals into 269021e on i18next:master.

@adrai adrai merged commit e3c6c06 into i18next:master Nov 9, 2021
@adrai
Copy link
Member

adrai commented Nov 9, 2021

thank you @pedrodurek
released with v11.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type-safe translations do not work with plurals
3 participants
@pedrodurek @coveralls @adrai