Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type-safe support to deep keyPrefix #1403

Merged
merged 3 commits into from
Nov 12, 2021
Merged

Add type-safe support to deep keyPrefix #1403

merged 3 commits into from
Nov 12, 2021

Conversation

pedrodurek
Copy link
Member

@pedrodurek pedrodurek commented Nov 11, 2021 •
edited
Loading

Closes #1387

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided

@pedrodurek
Copy link
Member Author

Hey @adrai, hold this PR for a moment, I'm just doing some performance tests

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.057% when pulling 219f3ab on pedrodurek:deep-key-prefix into 69dd913 on i18next:master.

@pedrodurek
Copy link
Member Author

Hey @adrai, it's good to go!

@adrai adrai merged commit f454af5 into i18next:master Nov 12, 2021
@adrai
Copy link
Member

adrai commented Nov 12, 2021

thank you, it's included in v11.14.2

@Vovan-VE Vovan-VE mentioned this pull request Nov 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type-safe translations do not work with keyPrefix
3 participants
@pedrodurek @coveralls @adrai