chore: update babel-plugin-tester to v11 #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripecosta
commented
Aug 14, 2024
| @@ -19,81 +19,81 @@ pluginTester({ | |||
| babelOptions: { filename: __filename, parserOpts: { plugins: ['jsx'] } }, | |||
| tests: [ | |||
| ` | |||
| import { Trans } from '../icu.macro' | |||
| import { Trans } from '../../../icu.macro' | |||
There was a problem hiding this comment.
babel-plugin-tester v11 has a different folder structure so these imports had to be updated.
|
|
||
| const d = 1; | ||
| const outside = plural\`\${d}, =0 { # } other { chose # }\`; | ||
| `, | ||
| snapshot: false, | ||
| error: /"plural``" can only be used inside <Trans> in "[^"]+" on line 5/, | ||
| error: /"plural``" can only be used inside <Trans> in "[^"]+" on line 6/, |
There was a problem hiding this comment.
v11 adds an empty line at the starts of the file so these lines numbers had to be updated.
| " | ||
| `; | ||
|
|
||
| exports[`unknown plugin > 1. unknown plugin > 1. unknown plugin 1`] = ` |
There was a problem hiding this comment.
This massive deletion is due to a previous version of babel-plugin-tester no longer auto determining the name of a plugin, which left these obsolete snapshots in. It now determines the plugin name again, so these are safe to get rid of.
|
@adrai linting was failing in CI. Don't understand why yet but I'll try to fix it and raise a separate PR for it |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates babel-plugin-tester to the latest version (v11).
Checklist
npm run test