Allow translate HOC to take a function #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
published with react-i18next@7.3.0 thank you for contributing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #369. It was slightly more complicated than just adding
if (typeof namespaces === 'function') namespaces = namespaces(props);, because when multiple of the same component were rendered, only the first one would run the function, then the closure in the HOC would have that result set tonamespacesfor every other.I'm not certain if
Translate.namespaceswas being used elsewhere, but now that value can also be a function. If that'll cause issues, let me know and I'll try to implement it another way.