Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typings for HOC's and fix imports #567

Merged
merged 5 commits into from
Oct 25, 2018
Merged

Conversation

schettino
Copy link
Collaborator

@schettino schettino commented Oct 23, 2018

Closes: #565 #563 #562 #568 #571

  • Fixed namespace type def and for when a extractor function is provided
  • Removed unneeded default imports
  • Improved types for hoc's

@coveralls
Copy link

coveralls commented Oct 23, 2018

Coverage Status

Coverage remained the same at 76.645% when pulling 61815c5 on schettino:ts into b979553 on i18next:master.

@jvgreenaway
Copy link

These changes look good to me

@schettino
Copy link
Collaborator Author

@jamuhl whenever it's possible, we can release this patch

@jamuhl jamuhl merged commit 19b411e into i18next:master Oct 25, 2018
@jamuhl
Copy link
Member

jamuhl commented Oct 25, 2018

published in react-i18next@8.1.2

thanks a lot for the work done here

@Vrajmas
Copy link

Vrajmas commented Oct 25, 2018

Thanks, best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants