Skip to content

Commit

Permalink
Merge branch 'master' into issue-3169
Browse files Browse the repository at this point in the history
  • Loading branch information
iBotPeaches committed Jul 20, 2023
2 parents 96119ea + ab40693 commit 1cfda44
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
fail-fast: true
matrix:
os: [ ubuntu-latest, macOS-latest, windows-latest ]
java: [ 8, 11, 17, 18, 19 ]
java: [ 8, 11, 17, 18, 19, 20 ]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
Expand Down
6 changes: 6 additions & 0 deletions brut.apktool/apktool-cli/src/main/java/brut/apktool/Main.java
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ public static void main(String[] args) throws BrutException {
// headless
System.setProperty("java.awt.headless", "true");

// Ignore stricter validation on zip files from java 11 onwards as this is a protection technique
// that applications use to thwart disassembly tools. We have protections in place for directory traversal
// and handling of bogus data in the zip header, so we can ignore this.
System.setProperty("jdk.nio.zipfs.allowDotZipEntry", "true");
System.setProperty("jdk.util.zip.disableZip64ExtraFieldValidation", "true");

// set verbosity default
Verbosity verbosity = Verbosity.NORMAL;

Expand Down
4 changes: 4 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ subprojects {
apply plugin: 'java'

test {
// https://github.com/iBotPeaches/Apktool/issues/3174
systemProperty 'jdk.nio.zipfs.allowDotZipEntry', 'true'
systemProperty 'jdk.util.zip.disableZip64ExtraFieldValidation', 'true'

testLogging {
exceptionFormat = 'full'
}
Expand Down

0 comments on commit 1cfda44

Please sign in to comment.