-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Disable auto generation dummy attributes #2463
Conversation
Thanks - I need to think about this. This is effectively destroys recompilation and leaves you without a non-working app. So I want to weigh things in my head. |
Well, in theory, everything may not work, but in practice I have not noticed any problems yet. Check on some apps. |
I'm leaning in a direction to not merge this, because dummy attributes are required in circumstance where the res type spec is destroyed, but yet the resource is referenced. So I'm curious what your use-case/background is for this? (outside of like making it look cleaner) |
Hi, dummy does not restore anything in the resource structure, only one garbage from which the apk can't be builded. The new dummy attribute format is no can't used by aapt, so the support with aapt2 has been fixed. It turns out that they fixed it in one place, and broke it in another. I am attaching to the user the ability to disable these problematic attributes. |
I really need this option. I always have to remove dummys manually in order to compile, and they are working fine so far. |
as an [option] this seems interesting . dont need to be the default , the person can just add it when wanted like --no-dummys . seems a good thing to be added to automate that step when its desired. |
I took a look at this again and nothing specific to this PR, but our method of loading configurations into the disassembly side is horrible. Its either class variables at the AndroLibResources, AndroLib, ArscDecoder, ResTable level. The Came to my mind when I saw a new value having to be added to a bunch of functions. etc |
Ok, i'm closing this pull request |
As for me, they are not needed and the code will be cleaner. Therefore, in the morning I decided to make this feature. Also will partially fix #2462.