Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove docker #3423

Merged
merged 1 commit into from
Nov 8, 2023
Merged

build: remove docker #3423

merged 1 commit into from
Nov 8, 2023

Conversation

iBotPeaches
Copy link
Owner

  • Reported issues with /tmp file within container due to aapt2/aapt copy
  • Reported issues with writing framework location
  • Reported issues with guide on how to map apk into location
  • Questions regarding how you mount or if you use tmpfs
  • Flaky build failures during CI process

Due to not really having this at the quality I expect, I will revert it all for now. If/when it returns I want to follow more of what I see that apkid does - https://github.com/rednaga/APKiD/blob/master/docker/apkid.sh

It seems to work and strikes a balance between documentation and examples

@iBotPeaches iBotPeaches merged commit 4441648 into master Nov 8, 2023
25 checks passed
@iBotPeaches iBotPeaches deleted the remove-docker branch November 8, 2023 11:44
@iBotPeaches iBotPeaches added this to the v2.9.1 milestone Nov 8, 2023
iBotPeaches added a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant