Add option to specify a file containing a list of file extensions that should not be compressed. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t should not be compressed. This makes it possible to specify a doNotCompress list with a lot of entries on systems that have a restriction on the length of the command line (i.e. Windows and Mac OS).
|
Interesting workaround. So we just populate a file with our structure and patch aapt to handle this. My only fear is both aapt/aapt2 would have to be patched. I need to research a bit more, because I forgot what we are looking at aapt1 vs aapt2. |
|
Exactly! I also opened a PR in the apktool repo with code changes required to use this new option. What exactly are your concerns? I changed both aapt and aapt2 and it seems to work as intended for both versions. Luckily, this part of the aapt command line interface didn't really change between versions, at least i as far as I can see. |
|
Apologies. Only one file expanded on mobile. I'll take a look again when home. |
|
Ah, I see! No problem!
|
|
Hi @iBotPeaches, did you have a chance to look into this yet? :) |
|
thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to specify a doNotCompress list with a lot of
entries on systems that have a restriction on the length of the command
line (i.e. Windows and Mac OS).
By adding this option, we now have an easy way to fix Issue 1272 in Apktool.
I'm not quite sure about the structure of this repo. Was it correct to base this on the apktool_9.0.0 branch? If not, let me know and I can change it.