Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP mission waypoint enforce altitude option #7644

Merged
merged 4 commits into from
Feb 15, 2022

Conversation

breadoven
Copy link
Collaborator

@breadoven breadoven commented Dec 2, 2021

Provides an option to force mission waypoint altitude to be achieved before moving on to the next waypoint. If the set altitude hasn't been achieved when the craft arrives at the waypoint it will hold and adjust the altitude as required with a target margin of 100cm. Planes use a spiral loiter whilst changing altitude. Option is set for the whole mission and applicable to basic and timed hold waypoints.

Tested on fixed wing in flight. Multirotor still needs flight testing.

Closes #6336.

@breadoven
Copy link
Collaborator Author

Tested on a multicopter and works fine. However, it needs #7645 to prevent toilet bowling like instability at the hold position during height adjustment. Not sure if this was an issue before for timed hold with nav_mc_wp_slowdown set OFF, looking at the code I'd have thought it was @DzikuVx ?

@breadoven
Copy link
Collaborator Author

Any objections to merging this @DzikuVx @stronnag ?

@stronnag
Copy link
Collaborator

stronnag commented Jan 9, 2022

+1 Nice (and belated) feature. My only nit-pick is that the user visible setting might be more intuitively named nav_wp_enforce_altitude or nav_wp_force_altitude rather than nav_wp_capture_altitude. But that's trivia.

@breadoven
Copy link
Collaborator Author

Yes I wasn't entirely sure about capture. Happy to change it to "enforce".

@breadoven breadoven changed the title WP mission waypoint altitude capture option WP mission waypoint enforce altitude option Jan 9, 2022
@DzikuVx DzikuVx added this to the 5.0 milestone Jan 10, 2022
@breadoven breadoven merged commit 36d36c9 into iNavFlight:master Feb 15, 2022
@breadoven breadoven deleted the abo_wp_capture_altitude branch April 8, 2022 07:19
@breadoven breadoven added the Release Notes Add this when a PR needs to be mentioned in the release notes label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Notes Add this when a PR needs to be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Waypoint type: "Circle/Loiter up/down"
3 participants