Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failsafe RC adjustment bug fix #7829

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

breadoven
Copy link
Collaborator

Closes #7826.

Ensures RC input adjustment is always disabled (posControl.flags.isAdjustingPosition set false) when failsafe active.

@stronnag stronnag mentioned this pull request Feb 13, 2022
Cleaner method
@breadoven
Copy link
Collaborator Author

Changed to clean up code (too many messy flag statements).

@stronnag OK ?

@stronnag
Copy link
Collaborator

Changed to clean up code (too many messy flag statements).

@stronnag OK ?

Work of art, old bean. (That's at least an OK)

@DzikuVx
Copy link
Member

DzikuVx commented Feb 21, 2022

@breadoven do we need a hotfix with this change?

@breadoven
Copy link
Collaborator Author

breadoven commented Feb 21, 2022

@breadoven do we need a hotfix with this change?

Not sure. I'm guessing the bug has been there for a while with this seemingly the only reported issue caused by it. It does cause a flyaway though just when you think RTH will save the day so certainly needs fixing ASAP.

@DzikuVx
Copy link
Member

DzikuVx commented Feb 21, 2022

Then a hotfix it is

@DzikuVx DzikuVx added this to the 4.1.1 milestone Feb 21, 2022
@0crap
Copy link
Contributor

0crap commented Mar 28, 2022

Any idea when this "hotfix" will be released?

@breadoven
Copy link
Collaborator Author

Any idea when this "hotfix" will be released?

Have you been affected by the same problem ?

@0crap
Copy link
Contributor

0crap commented Mar 29, 2022

I'm glad I've not.
But I don't want to jinx myself for the upcoming season.
It's marked as an hotfix for a good reason I assume.

@0crap
Copy link
Contributor

0crap commented Apr 2, 2022

@breadoven Looking at the code, I get the impression this only applies to Multirotors and not for example planes.
Is my understanding correct?

@breadoven
Copy link
Collaborator Author

@breadoven Looking at the code, I get the impression this only applies to Multirotors and not for example planes. Is my understanding correct?

Affects multirotors and planes although perhaps RC adjustment is used more often with multirotors than planes so they're more susceptible.

@0crap
Copy link
Contributor

0crap commented Apr 3, 2022

Thx!

@DzikuVx DzikuVx modified the milestones: 4.1.1, 5.0 Apr 12, 2022
@DzikuVx DzikuVx merged commit a48c458 into iNavFlight:master Apr 27, 2022
@breadoven breadoven deleted the abo_failsafe_RTH_RCPos_Fix branch June 4, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants