-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor u-blox hardware version detection; Add support for u-blox 10 series #8058
Conversation
Perfect. Do it properly now rather than wait for Ublox to break it again. |
Bench tested on M8N, OK. |
hu hu :) @digitalentity codes INAV again :) |
Tested on NEO-M9N and MAX-M10S, works fine. @digitalentity |
Is this change in RC1? Does not work with BN-220T or BN-180 (Not sure what I have in the Dart 250G as I cannot check because it is glued in). Setup identical to 4.1. In 4.1 all fine and UBLOX as well as UBLOX7 works. In 5.0 GPS is not configured anymore and blinks in 1s default interval. Blue LED for TX also blinks with long on and short off 1s intervals. Got it working once by setting up in 4.1, then flashed 5.0 without power cycle and the GPS stayed in UBLOX7 config mode. Then it worked in 5.0. But after power cycle it is not detected again. So the handshake doesn't seem to work on RC1 |
It is not in RC1, planned for RC2. |
OK I'll. try the master build then to see if it is working there. |
The UBLOX change was merged into the |
Here, UBLOX(7) GPS detection is working as usual with or without this PR on 5.0.0. |
OK thanks for the info. Then I will check again with RC2 and report back. I have no build envoronment set up right now. |
So I found the problem. |
Supersedes #8056
U-blox version is a string. Conversion to an integer and comparison worked until U-blox 10 by mere chance. Because there are no guarantees that version string is a hex number either, we should switch to treating it as a string and comparing what we get from a GPS module to all possible strings seen in the wild.