Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor u-blox hardware version detection; Add support for u-blox 10 series #8058

Merged
merged 2 commits into from
May 28, 2022

Conversation

digitalentity
Copy link
Member

Supersedes #8056

U-blox version is a string. Conversion to an integer and comparison worked until U-blox 10 by mere chance. Because there are no guarantees that version string is a hex number either, we should switch to treating it as a string and comparing what we get from a GPS module to all possible strings seen in the wild.

@digitalentity digitalentity added this to the 5.0 milestone May 28, 2022
@stronnag
Copy link
Collaborator

Perfect. Do it properly now rather than wait for Ublox to break it again.

@stronnag
Copy link
Collaborator

Bench tested on M8N, OK.

@DzikuVx DzikuVx changed the base branch from master to release_5.0.0 May 28, 2022 11:27
@DzikuVx
Copy link
Member

DzikuVx commented May 28, 2022

hu hu :) @digitalentity codes INAV again :)
Awesome, so let's put it into 5.0. I just changed the base branch and let's close #8056

@DzikuVx DzikuVx merged commit 63a60ad into release_5.0.0 May 28, 2022
@DzikuVx DzikuVx deleted the de_ublox10 branch May 28, 2022 12:07
@MATEKSYS
Copy link
Contributor

Tested on NEO-M9N and MAX-M10S, works fine. @digitalentity

@b14ckyy
Copy link
Collaborator

b14ckyy commented May 30, 2022

Is this change in RC1?

Does not work with BN-220T or BN-180 (Not sure what I have in the Dart 250G as I cannot check because it is glued in).

Setup identical to 4.1. In 4.1 all fine and UBLOX as well as UBLOX7 works. In 5.0 GPS is not configured anymore and blinks in 1s default interval. Blue LED for TX also blinks with long on and short off 1s intervals.

Got it working once by setting up in 4.1, then flashed 5.0 without power cycle and the GPS stayed in UBLOX7 config mode. Then it worked in 5.0. But after power cycle it is not detected again. So the handshake doesn't seem to work on RC1

@stronnag
Copy link
Collaborator

It is not in RC1, planned for RC2.

@b14ckyy
Copy link
Collaborator

b14ckyy commented May 31, 2022

OK I'll. try the master build then to see if it is working there.

@stronnag
Copy link
Collaborator

The UBLOX change was merged into the release_5.0.0 branch after RC1 (hence it will be in RC2).
Not in master until after release re-merge.

@stronnag
Copy link
Collaborator

Here, UBLOX(7) GPS detection is working as usual with or without this PR on 5.0.0.

@b14ckyy
Copy link
Collaborator

b14ckyy commented May 31, 2022

OK thanks for the info. Then I will check again with RC2 and report back. I have no build envoronment set up right now.
With the BN-220T (just realized that there is a backup battery on it so it must be the 220T) on the F411-WSE on UART1 I am not able to get GPS working on RC1 though. Maybe I should open a separate issue ticket then.

@b14ckyy
Copy link
Collaborator

b14ckyy commented May 31, 2022

So I found the problem.
During previous experimenting to get GPS working on softserial (what never worked) I have set gps_auto_baud=OFF. after turning it back on it worked on 5.0 RC1.
I just don't get why it was working like this on 4.1 but not on 5.0....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants