[SITL] disable nagle for UART TCP #9079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmosca
pushed a commit
that referenced
this pull request
May 29, 2023
sensei-hacker
pushed a commit
to sensei-hacker/inav_unofficial_targets
that referenced
this pull request
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SITL UART workload (small packets, essential half-duplex for MSP) performs badly on systems where Nagle is enabled by default.
This PR sets
TCP_NODELAYon TCP (UART) sockets, resulting in an order of magnitude increase inMSPthroughput. This is likely to be similar for other workloads, as they all use small packet sizes.MSP test: