Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch MatekF405TE to use burst DMA #9277

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

DzikuVx
Copy link
Member

@DzikuVx DzikuVx commented Sep 5, 2023

@MATEKSYS can you confirm DSHOT is working now? I'm not sure where I put the hardware to test

@DzikuVx DzikuVx added this to the 7.0 milestone Sep 5, 2023
@MATEKSYS
Copy link
Contributor

MATEKSYS commented Sep 6, 2023

DSHOT is working.
seems you add dshot burst in a wrong target file.
should be MATEKF405TE, rather than MATEKF411TE

@DzikuVx
Copy link
Member Author

DzikuVx commented Sep 6, 2023

Now it should be fine. If you confirm DSHOT is not working with 405TE we can merge immediately

@MATEKSYS
Copy link
Contributor

MATEKSYS commented Sep 6, 2023

I have tested it yesterday, 8 motors all working with DSHOT burst.

@DzikuVx DzikuVx added the Release Notes Add this when a PR needs to be mentioned in the release notes label Sep 6, 2023
@DzikuVx DzikuVx merged commit fd52270 into master Sep 6, 2023
14 checks passed
@DzikuVx DzikuVx deleted the dzikuvx-switch-matelf405te-top-burst-dma branch September 6, 2023 18:01
rmaia3d pushed a commit to rmaia3d/inav that referenced this pull request Sep 9, 2023
…elf405te-top-burst-dma

Switch MatekF405TE to use burst DMA
@rmaia3d
Copy link
Contributor

rmaia3d commented Sep 16, 2023

Since I already have a Matek F405 mini-TE in hand, I hooked S1 to S4 outputs to an oscilloscope and ran some tests:

This is the "vanilla" Inav 6.1.1 output, DSHOT 300 at 0% and 50% throttle:
Ch1 is S1, yellow line
Ch2 is S2, cyan line
Ch3 is S3, magenta line
Ch4 is S4, blue line
IMG_2728
IMG_2730

@rmaia3d
Copy link
Contributor

rmaia3d commented Sep 16, 2023

This is after applying the changes in this PR (same setup as above):

IMG_2731
IMG_2732

As can be seen, not much difference other than the channel groupings seem more aligned between themselves.

What draws the attention is the fact that S3 (Ch3, magenta line) is mirrored with regards to the other ones. This didn't change between before DMA burst and after.

So, even though the motor may be running on S3, did anyone actually test it to verify the correct throttle input is being recognized?

@rmaia3d
Copy link
Contributor

rmaia3d commented Sep 16, 2023

For reference, here is the Betaflight 4.4.2 output on the same board, same setup (DSHOT 300) and also at 0 and 50% throttle. Note how S3 (magenta) isn't mirrored, it's exactly the same as the others.

IMG_2733
IMG_2734

@rmaia3d rmaia3d mentioned this pull request Sep 17, 2023
rmaia3d added a commit to rmaia3d/inav that referenced this pull request Oct 2, 2023
…itch-matelf405te-top-burst-dma"

This reverts commit 2a2396f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Notes Add this when a PR needs to be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants