Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore tasks.json and use tabs in C files #9295

Merged
merged 2 commits into from
Sep 16, 2023

Conversation

MrD-RC
Copy link
Collaborator

@MrD-RC MrD-RC commented Sep 16, 2023

Added ignore flags for

  • .vscode\tasks.json
  • .vscode\c_cpp_properties.json

Changed settings.json to use tabs, not spaces for C file types.

Added ignore flags for
- .vscode\tasks.json
- .vscode\c_cpp_properties.json

Changed settings.json to use tabs, not spaces for C file types.
@MrD-RC MrD-RC added this to the 7.0 milestone Sep 16, 2023
@MrD-RC MrD-RC requested a review from mmosca September 16, 2023 13:39
@mmosca
Copy link
Collaborator

mmosca commented Sep 16, 2023

I am on the camp of spaces as a good compromise, but the original pr with the rules was meant for discussion.

I am ok either way, and other editors can be setup to match.

Mixing tabs and spaces on the other hand is bad and leads to things being formatted wrong, specially when tabs are configured to be displayed as anything but 8 spaces.

@stronnag
Copy link
Collaborator

Dev docs links to this style guide which mandates 4 spaces.

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Sep 16, 2023

Has that changed? I always thought it was the opposite. Tabs should be hard tabs, equating to 4 spaces.

@stronnag
Copy link
Collaborator

No it's always been 4 spaces, no hard tabs. The style guide item was last updated 2017-07-04.

@mmosca
Copy link
Collaborator

mmosca commented Sep 16, 2023

I create the pr that set spaces as default because of #9173

Use spaces not tabs
@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Sep 16, 2023

OK, I've corrected the PR to remove the tab part. Shame, I've always hated spaces for indents. Ah well, the other parts can be merged. The constant want to update the tasks.json file is a bit annoying.

@mmosca
Copy link
Collaborator

mmosca commented Sep 16, 2023

OK, I've corrected the PR to remove the tab part. Shame, I've always hated spaces for indents. Ah well, the other parts can be merged. The constant want to update the tasks.json file is a bit annoying.

So did I, but that fight was lost a looong time ago. :(
These days spaces are the norm, specially now that python and yaml are so popular... 1 tab, counts as 1 space for the indentation in those...

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Sep 16, 2023

One more thing to make me hate Python 🤣 Just use proper structure!!!

@MrD-RC MrD-RC merged commit abca7e2 into master Sep 16, 2023
14 checks passed
@MrD-RC MrD-RC deleted the MrD_Updates-to-vscode-settings-and-ignores branch September 16, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants