Fix link style load timing issue in window popups #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GerardasB
commented
Sep 3, 2024
...umeric-input-UiAbstract-InputEditorSize-UiAbstract-Range-default-visual-1-chromium-linux.png
Show resolved
Hide resolved
|
@Mergifyio backport release/4.16.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Update playwright * Run e2e on preview build * Add trackConsole * Add a test * Fix by waiting for link styles to load before rendering. * Fix tests * rush change * Fix linter error * Copy adoptedStyleSheets async. (cherry picked from commit e4a5c8c) # Conflicts: # common/config/rush/pnpm-lock.yaml
GerardasB
added a commit
that referenced
this pull request
Sep 4, 2024
* Update playwright * Run e2e on preview build * Add trackConsole * Add a test * Fix by waiting for link styles to load before rendering. * Fix tests * rush change * Fix linter error * Copy adoptedStyleSheets async.
GerardasB
added a commit
that referenced
this pull request
Sep 4, 2024
* Fix link style load timing issue in window popups (#994) * Update playwright * Run e2e on preview build * Add trackConsole * Add a test * Fix by waiting for link styles to load before rendering. * Fix tests * rush change * Fix linter error * Copy adoptedStyleSheets async. (cherry picked from commit e4a5c8c) # Conflicts: # common/config/rush/pnpm-lock.yaml * rush update --------- Co-authored-by: GerardasB <10091419+GerardasB@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes #986 a timing issue where stylesheets are not loaded in a popout widget before the React lifecycle runs, causing issues in the Viewport
size != 0assertion.Testing
Added additional e2e tests.