review fixes + don't recurse if split length is 1

iamkun · Jun 28, 2021 · 816f1e8 · 816f1e8
1 parent 0529560
commit 816f1e8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/index.js b/src/index.js
@@ -21,7 +21,7 @@ const parseLocale = (preset, object, isLocal) => {
       l = presetLower
     }
     const presetSplit = preset.split('-')
-    if (!l && presetSplit.length) {
+    if (!l && presetSplit.length > 1) {
       return parseLocale(presetSplit[0])
     }
   } else {

diff --git a/test/plugin/localizedFormat.test.js b/test/plugin/localizedFormat.test.js
@@ -97,13 +97,13 @@ it('Uses the localized lowercase formats if defined', () => {
 })
 
 it('Uses fallback to xx if xx-yy not available', () => {
-  expect(dayjs('2019-02-01').locale('es-yy').format('L'))
-    .toBe('01/02/2019')
+  expect(dayjs('2019-02-01').locale('en-yy').format('MMMM'))
+    .toBe('February')
 })
 
 it('Uses xx-yy if xx-YY is provided', () => {
-  expect(dayjs('2019-02-01').locale('es-US').format('L'))
-    .toBe('01/02/2019')
+  expect(dayjs('2019-02-01').locale('es-US').format('MMMM'))
+    .toBe('febrero')
 })
 
 it('Uses the localized uppercase formats as a base for lowercase formats, if not defined', () => {