Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong locale id with relativeTime (past) #234

Closed
mkhuda opened this issue Jun 8, 2018 · 2 comments
Closed

wrong locale id with relativeTime (past) #234

mkhuda opened this issue Jun 8, 2018 · 2 comments

Comments

@mkhuda
Copy link

mkhuda commented Jun 8, 2018 •
edited
Loading

Hi, I tried dayjs using relativeTime plugin.
This is the code:

dayjs(mytime).fromNow(),

But the result is yang lalu 3 jam (for example), it should be 3 jam yang lalu for Indonesian.

Looks like here:

dayjs/src/locale/id.js

Line 9 in 2814f2f

past: 'yang lalu %s',

Thank you
@iamkun
Copy link
Owner

iamkun commented Jun 11, 2018

THX, will check this.

@iamkun iamkun closed this as completed in 1ebbeb8 Jun 11, 2018
iamkun pushed a commit that referenced this issue Jun 11, 2018
@semantic-release-bot
chore(release): 1.6.7 [skip ci]
043ea4a 
## [1.6.7](v1.6.6...v1.6.7) (2018-06-11)

### Bug Fixes

* fix id locale ([1ebbeb8](1ebbeb8)), closes [#234](#234)
@iamkun
Copy link
Owner

iamkun commented Jun 11, 2018

🎉 This issue has been resolved in version 1.6.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.6.7 [skip ci]
5a7bfa1 
## [1.6.7](iamkun/dayjs@v1.6.6...v1.6.7) (2018-06-11)

### Bug Fixes

* fix id locale ([1ebbeb8](iamkun/dayjs@1ebbeb8)), closes [#234](iamkun/dayjs#234)
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.6.7 [skip ci]
84af227 
## [1.6.7](iamkun/dayjs@v1.6.6...v1.6.7) (2018-06-11)

### Bug Fixes

* fix id locale ([1ebbeb8](iamkun/dayjs@1ebbeb8)), closes [#234](iamkun/dayjs#234)
allmoviestvshowslistsfilmography28 added a commit to allmoviestvshowslistsfilmography28/dayjs that referenced this issue Sep 12, 2024
@allmoviestvshowslistsfilmography28 @semantic-release-bot
chore(release): 1.6.7 [skip ci]
9573df6 
## [1.6.7](iamkun/dayjs@v1.6.6...v1.6.7) (2018-06-11)

### Bug Fixes

* fix id locale ([048f4ee](iamkun/dayjs@048f4ee)), closes [#234](iamkun/dayjs#234)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkhuda @iamkun