Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customizing "am" / "pm" strings with locale #578

Closed
gka opened this issue Apr 24, 2019 · 5 comments · Fixed by #580
Closed

Allow customizing "am" / "pm" strings with locale #578

gka opened this issue Apr 24, 2019 · 5 comments · Fixed by #580
Labels
🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt released

Comments

@gka
Copy link

gka commented Apr 24, 2019 •
edited by issuehunt-oss bot
Loading

Issuehunt badges

Some organizations specifically require the use of "a.m." and "p.m." instead of "am" and "pm". It would be very useful if the two strings could be customized using a custom locale -- they appear to be hard-coded right now.

IssueHunt Summary

iamkun iamkun has been rewarded.

Backers (Total: $50.00)

Submitted pull Requests

Tips

IssueHunt has been backed by the following sponsors. Become a sponsor
@ghost
Copy link

ghost commented Apr 25, 2019

Agreed! And some locales use their own language instead of AM/PM.

And what's the appropriate locale key of this feature?

@IssueHuntBot
Copy link

@IssueHunt has funded $50.00 to this issue.

iamkun added a commit that referenced this issue Apr 25, 2019
@iamkun
fix: Allow customizing "am" / "pm" strings with locale meridiem function
734c01a 
fix #578
@iamkun iamkun mentioned this issue Apr 25, 2019
Merged
iamkun added a commit that referenced this issue Apr 26, 2019
@iamkun
fix: Allow customizing "am" / "pm" strings with locale meridiem funct…
576e93e 
…ion (#580)

* fix: Allow customizing "am" / "pm" strings with locale meridiem function

fix #578

* test: Add meridiem test

* docs: Update meridiem docs
iamkun pushed a commit that referenced this issue Apr 26, 2019
@semantic-release-bot
chore(release): 1.8.13 [skip ci]
68a04e1 
## [1.8.13](v1.8.12...v1.8.13) (2019-04-26)

### Bug Fixes

* Add missing relativeTime and formats for some locales ([#560](#560)) ([96b917e](96b917e))
* Add weekday (locale aware day of the week) plugin ([#569](#569)) ([9007cc5](9007cc5)), closes [#559](#559)
* Allow customizing "am" / "pm" strings with locale meridiem function ([#580](#580)) ([576e93e](576e93e)), closes [#578](#578)
* Fix `.add` day/week decimal rouding bug ([800f6c9](800f6c9))
* Fix `.diff` type definition error ([#565](#565)) ([c4921ae](c4921ae)), closes [#561](#561)
* Fix CustomParseFormat plugin bug ([#568](#568)) ([1f5a9db](1f5a9db)), closes [#555](#555)
* Fix relativeTime plugin Math.round bug ([40bea40](40bea40))
* skip square brackets in  buddhistEra, advancedFormat plugins ([#556](#556)) ([9279718](9279718)), closes [#554](#554)
* Update Indonesian locale([#574](#574)) ([0aa7143](0aa7143))
* Update locale month to support both array and function ([#581](#581)) ([b6599d3](b6599d3))
* Update LocalizedFormat plugin lowercase formats logic ([#557](#557)) ([d409304](d409304))
@iamkun
Copy link
Owner

iamkun commented Apr 26, 2019

🎉 This issue has been resolved in version 1.8.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@janat08
Copy link

janat08 commented Jun 10, 2019

There're a lot of issues on issuehunt that are already resolved: https://issuehunt.io/issues?search=dayjs&page=1. You could just claim them yourself @iamkun.

@issuehunt-oss
Copy link

issuehunt-oss bot commented Aug 12, 2019

@iamkun has rewarded $45.00 to @iamkun. See it on IssueHunt

  • 💰 Total deposit: $50.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $5.00

@issuehunt-oss issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label Aug 12, 2019
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.13 [skip ci]
b38f060 
## [1.8.13](iamkun/dayjs@v1.8.12...v1.8.13) (2019-04-26)

### Bug Fixes

* Add missing relativeTime and formats for some locales ([#560](iamkun/dayjs#560)) ([96b917e](iamkun/dayjs@96b917e))
* Add weekday (locale aware day of the week) plugin ([#569](iamkun/dayjs#569)) ([9007cc5](iamkun/dayjs@9007cc5)), closes [#559](iamkun/dayjs#559)
* Allow customizing "am" / "pm" strings with locale meridiem function ([#580](iamkun/dayjs#580)) ([576e93e](iamkun/dayjs@576e93e)), closes [#578](iamkun/dayjs#578)
* Fix `.add` day/week decimal rouding bug ([800f6c9](iamkun/dayjs@800f6c9))
* Fix `.diff` type definition error ([#565](iamkun/dayjs#565)) ([c4921ae](iamkun/dayjs@c4921ae)), closes [#561](iamkun/dayjs#561)
* Fix CustomParseFormat plugin bug ([#568](iamkun/dayjs#568)) ([1f5a9db](iamkun/dayjs@1f5a9db)), closes [#555](iamkun/dayjs#555)
* Fix relativeTime plugin Math.round bug ([40bea40](iamkun/dayjs@40bea40))
* skip square brackets in  buddhistEra, advancedFormat plugins ([#556](iamkun/dayjs#556)) ([9279718](iamkun/dayjs@9279718)), closes [#554](iamkun/dayjs#554)
* Update Indonesian locale([#574](iamkun/dayjs#574)) ([0aa7143](iamkun/dayjs@0aa7143))
* Update locale month to support both array and function ([#581](iamkun/dayjs#581)) ([b6599d3](iamkun/dayjs@b6599d3))
* Update LocalizedFormat plugin lowercase formats logic ([#557](iamkun/dayjs#557)) ([d409304](iamkun/dayjs@d409304))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.13 [skip ci]
ec17709 
## [1.8.13](iamkun/dayjs@v1.8.12...v1.8.13) (2019-04-26)

### Bug Fixes

* Add missing relativeTime and formats for some locales ([#560](iamkun/dayjs#560)) ([96b917e](iamkun/dayjs@96b917e))
* Add weekday (locale aware day of the week) plugin ([#569](iamkun/dayjs#569)) ([9007cc5](iamkun/dayjs@9007cc5)), closes [#559](iamkun/dayjs#559)
* Allow customizing "am" / "pm" strings with locale meridiem function ([#580](iamkun/dayjs#580)) ([576e93e](iamkun/dayjs@576e93e)), closes [#578](iamkun/dayjs#578)
* Fix `.add` day/week decimal rouding bug ([800f6c9](iamkun/dayjs@800f6c9))
* Fix `.diff` type definition error ([#565](iamkun/dayjs#565)) ([c4921ae](iamkun/dayjs@c4921ae)), closes [#561](iamkun/dayjs#561)
* Fix CustomParseFormat plugin bug ([#568](iamkun/dayjs#568)) ([1f5a9db](iamkun/dayjs@1f5a9db)), closes [#555](iamkun/dayjs#555)
* Fix relativeTime plugin Math.round bug ([40bea40](iamkun/dayjs@40bea40))
* skip square brackets in  buddhistEra, advancedFormat plugins ([#556](iamkun/dayjs#556)) ([9279718](iamkun/dayjs@9279718)), closes [#554](iamkun/dayjs#554)
* Update Indonesian locale([#574](iamkun/dayjs#574)) ([0aa7143](iamkun/dayjs@0aa7143))
* Update locale month to support both array and function ([#581](iamkun/dayjs#581)) ([b6599d3](iamkun/dayjs@b6599d3))
* Update LocalizedFormat plugin lowercase formats logic ([#557](iamkun/dayjs#557)) ([d409304](iamkun/dayjs@d409304))
allmoviestvshowslistsfilmography28 added a commit to allmoviestvshowslistsfilmography28/dayjs that referenced this issue Sep 12, 2024
@allmoviestvshowslistsfilmography28 @semantic-release-bot
chore(release): 1.8.13 [skip ci]
a7e1712 
## [1.8.13](iamkun/dayjs@v1.8.12...v1.8.13) (2019-04-26)

### Bug Fixes

* Add missing relativeTime and formats for some locales ([#560](iamkun/dayjs#560)) ([aaf5a76](iamkun/dayjs@aaf5a76))
* Add weekday (locale aware day of the week) plugin ([#569](iamkun/dayjs#569)) ([95c7666](iamkun/dayjs@95c7666)), closes [#559](iamkun/dayjs#559)
* Allow customizing "am" / "pm" strings with locale meridiem function ([#580](iamkun/dayjs#580)) ([d2056fa](iamkun/dayjs@d2056fa)), closes [#578](iamkun/dayjs#578)
* Fix `.add` day/week decimal rouding bug ([20be555](iamkun/dayjs@20be555))
* Fix `.diff` type definition error ([#565](iamkun/dayjs#565)) ([10f35df](iamkun/dayjs@10f35df)), closes [#561](iamkun/dayjs#561)
* Fix CustomParseFormat plugin bug ([#568](iamkun/dayjs#568)) ([3161ebe](iamkun/dayjs@3161ebe)), closes [#555](iamkun/dayjs#555)
* Fix relativeTime plugin Math.round bug ([cd89839](iamkun/dayjs@cd89839))
* skip square brackets in  buddhistEra, advancedFormat plugins ([#556](iamkun/dayjs#556)) ([1f89ee7](iamkun/dayjs@1f89ee7)), closes [#554](iamkun/dayjs#554)
* Update Indonesian locale([#574](iamkun/dayjs#574)) ([77540a2](iamkun/dayjs@77540a2))
* Update locale month to support both array and function ([#581](iamkun/dayjs#581)) ([4f1f4d0](iamkun/dayjs@4f1f4d0))
* Update LocalizedFormat plugin lowercase formats logic ([#557](iamkun/dayjs#557)) ([656a993](iamkun/dayjs@656a993))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Allow customizing "am" / "pm" strings with locale meridiem function iamkun/dayjs
4 participants
@gka @janat08 @iamkun @IssueHuntBot