Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weekOfYear shows wrong calender week at the turn of the year #760

Closed
Khazl opened this issue Dec 29, 2019 · 2 comments · Fixed by BlueWallet/BlueWallet#862 · May be fixed by cds-snc/apply-for-a-grant#32
Closed

weekOfYear shows wrong calender week at the turn of the year #760

Khazl opened this issue Dec 29, 2019 · 2 comments · Fixed by BlueWallet/BlueWallet#862 · May be fixed by cds-snc/apply-for-a-grant#32
Labels
released

Comments

@Khazl
Copy link

Khazl commented Dec 29, 2019

Describe the bug
I probably found a bug in the weekOfYear plugin.
The 2019-12-30 should be calender week 1 but it shows as calender week 53.

Here my example at codepen:
https://codepen.io/khazl/pen/NWPvoYb?editors=0012

Calender weeks:
http://www.whatweekisit.org/

Information

  • Day.js Version 1.8.17
  • Browser Chrome latest
@iamkun iamkun closed this as completed in 79b86db Dec 30, 2019
@iamkun
Copy link
Owner

iamkun commented Dec 30, 2019

Thanks. Will fix in next release

iamkun pushed a commit that referenced this issue Jan 6, 2020
@semantic-release-bot
chore(release): 1.8.19 [skip ci]
731b947 
## [1.8.19](v1.8.18...v1.8.19) (2020-01-06)

### Bug Fixes

* Add UpdateLocale plugin to update a locale's properties ([#766](#766)) ([82ce2ba](82ce2ba))
* Fix CustomParseFormat Plugin 'YYYY-MM' use first day of the month ([ba709ec](ba709ec)), closes [#761](#761)
* Fix CustomParseFormat Plugin to set correct locale ([66ce23f](66ce23f))
* Fix WeekOfYear Plugin wrong calender week number bug ([79b86db](79b86db)), closes [#760](#760)
* Update RelativeTime plugin to support function to make additional processing ([#767](#767)) ([4bd9250](4bd9250))
* Update ru, uk, cs locale to support relativeTime with plural ([3f080f7](3f080f7))
@iamkun
Copy link
Owner

iamkun commented Jan 6, 2020

🎉 This issue has been resolved in version 1.8.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Jan 6, 2020
@snyk-bot snyk-bot mentioned this issue Mar 5, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Apr 9, 2020
Open
@ttusek ttusek mentioned this issue Dec 9, 2020
Closed
@grzegorz-s grzegorz-s mentioned this issue Jan 21, 2021
Merged
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.19 [skip ci]
e29135b 
## [1.8.19](iamkun/dayjs@v1.8.18...v1.8.19) (2020-01-06)

### Bug Fixes

* Add UpdateLocale plugin to update a locale's properties ([#766](iamkun/dayjs#766)) ([82ce2ba](iamkun/dayjs@82ce2ba))
* Fix CustomParseFormat Plugin 'YYYY-MM' use first day of the month ([ba709ec](iamkun/dayjs@ba709ec)), closes [#761](iamkun/dayjs#761)
* Fix CustomParseFormat Plugin to set correct locale ([66ce23f](iamkun/dayjs@66ce23f))
* Fix WeekOfYear Plugin wrong calender week number bug ([79b86db](iamkun/dayjs@79b86db)), closes [#760](iamkun/dayjs#760)
* Update RelativeTime plugin to support function to make additional processing ([#767](iamkun/dayjs#767)) ([4bd9250](iamkun/dayjs@4bd9250))
* Update ru, uk, cs locale to support relativeTime with plural ([3f080f7](iamkun/dayjs@3f080f7))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.19 [skip ci]
bb1f0b3 
## [1.8.19](iamkun/dayjs@v1.8.18...v1.8.19) (2020-01-06)

### Bug Fixes

* Add UpdateLocale plugin to update a locale's properties ([#766](iamkun/dayjs#766)) ([82ce2ba](iamkun/dayjs@82ce2ba))
* Fix CustomParseFormat Plugin 'YYYY-MM' use first day of the month ([ba709ec](iamkun/dayjs@ba709ec)), closes [#761](iamkun/dayjs#761)
* Fix CustomParseFormat Plugin to set correct locale ([66ce23f](iamkun/dayjs@66ce23f))
* Fix WeekOfYear Plugin wrong calender week number bug ([79b86db](iamkun/dayjs@79b86db)), closes [#760](iamkun/dayjs#760)
* Update RelativeTime plugin to support function to make additional processing ([#767](iamkun/dayjs#767)) ([4bd9250](iamkun/dayjs@4bd9250))
* Update ru, uk, cs locale to support relativeTime with plural ([3f080f7](iamkun/dayjs@3f080f7))
allmoviestvshowslistsfilmography28 added a commit to allmoviestvshowslistsfilmography28/dayjs that referenced this issue Sep 12, 2024
@allmoviestvshowslistsfilmography28 @semantic-release-bot
chore(release): 1.8.19 [skip ci]
1450a17 
## [1.8.19](iamkun/dayjs@v1.8.18...v1.8.19) (2020-01-06)

### Bug Fixes

* Add UpdateLocale plugin to update a locale's properties ([#766](iamkun/dayjs#766)) ([ab89933](iamkun/dayjs@ab89933))
* Fix CustomParseFormat Plugin 'YYYY-MM' use first day of the month ([8adb447](iamkun/dayjs@8adb447)), closes [#761](iamkun/dayjs#761)
* Fix CustomParseFormat Plugin to set correct locale ([2d220d9](iamkun/dayjs@2d220d9))
* Fix WeekOfYear Plugin wrong calender week number bug ([943e479](iamkun/dayjs@943e479)), closes [#760](iamkun/dayjs#760)
* Update RelativeTime plugin to support function to make additional processing ([#767](iamkun/dayjs#767)) ([674aa98](iamkun/dayjs@674aa98))
* Update ru, uk, cs locale to support relativeTime with plural ([82b6188](iamkun/dayjs@82b6188))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
2 participants
@Khazl @iamkun